Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Issue 274943003: Create new histrograms for ExtensionPermission enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/crx_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
index e3acae2d8295510babedd16abf3cc35ccfae98ae..ba6af7c509fc3e6197ac813e1537470043ff2edf 100644
--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
@@ -509,7 +509,7 @@ void WebstorePrivateBeginInstallWithManifest3Function::InstallUIProceed() {
// for all extension installs, so we only need to record the web store
// specific histogram here.
ExtensionService::RecordPermissionMessagesHistogram(
- dummy_extension_.get(), "Extensions.Permissions_WebStoreInstall");
+ dummy_extension_.get(), "Extensions.Permissions_WebStoreInstall2");
// Matches the AddRef in RunAsync().
Release();
@@ -525,15 +525,14 @@ void WebstorePrivateBeginInstallWithManifest3Function::InstallUIAbort(
// The web store install histograms are a subset of the install histograms.
// We need to record both histograms here since CrxInstaller::InstallUIAbort
// is never called for web store install cancellations.
- std::string histogram_name = user_initiated ?
- "Extensions.Permissions_WebStoreInstallCancel" :
- "Extensions.Permissions_WebStoreInstallAbort";
+ std::string histogram_name =
+ user_initiated ? "Extensions.Permissions_WebStoreInstallCancel2"
+ : "Extensions.Permissions_WebStoreInstallAbort2";
ExtensionService::RecordPermissionMessagesHistogram(dummy_extension_.get(),
histogram_name.c_str());
- histogram_name = user_initiated ?
- "Extensions.Permissions_InstallCancel" :
- "Extensions.Permissions_InstallAbort";
+ histogram_name = user_initiated ? "Extensions.Permissions_InstallCancel2"
+ : "Extensions.Permissions_InstallAbort2";
ExtensionService::RecordPermissionMessagesHistogram(dummy_extension_.get(),
histogram_name.c_str());
« no previous file with comments | « no previous file | chrome/browser/extensions/crx_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698