Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1865)

Issue 2748973003: Revert of Remove depenedency on GYP_DEFINES in clang gclient hook (Closed)

Created:
3 years, 9 months ago by agrieve
Modified:
3 years, 9 months ago
Reviewers:
krasin1, Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove depenedency on GYP_DEFINES in clang gclient hook (patchset #2 id:20001 of https://codereview.chromium.org/2733043002/ ) Reason for revert: update.py is used by non-chromium devs. See: https://codereview.chromium.org/2749003002/ Original issue's description: > Remove dependency on GYP_DEFINES in clang gclient hook > > The gold plugin is needed only for linux official builds. However, since > it's only 17MB, it's better to always download it rather than having it > depend on GYP_DEFINES. > > BUG=570091, 699210 > > Review-Url: https://codereview.chromium.org/2733043002 > Cr-Commit-Position: refs/heads/master@{#455991} > Committed: https://chromium.googlesource.com/chromium/src/+/57310cedbe5d558ba806b3f60f752b84e20a65eb TBR=thakis@chromium.org,krasin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=570091, 699210 Review-Url: https://codereview.chromium.org/2748973003 Cr-Commit-Position: refs/heads/master@{#456729} Committed: https://chromium.googlesource.com/chromium/src/+/081e3434463b81db9b72d96e4a4c5e8016f02b60

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tools/clang/scripts/update.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
agrieve
Created Revert of Remove depenedency on GYP_DEFINES in clang gclient hook
3 years, 9 months ago (2017-03-14 15:45:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748973003/1
3 years, 9 months ago (2017-03-14 15:46:46 UTC) #3
krasin1
lgtm
3 years, 9 months ago (2017-03-14 16:25:07 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 16:42:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/081e3434463b81db9b72d96e4a4c...

Powered by Google App Engine
This is Rietveld 408576698