Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2749003002: Let the users skip the gold plugin installation

Created:
3 years, 9 months ago by Alexander Potapenko
Modified:
3 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org, krasin1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let the users skip the gold plugin installation BUG=None R=thakis@chromium.org TEST=local run

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/clang/scripts/update.py View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Alexander Potapenko
Hi Nico, I'm using update.py to fetch the Clang which I then use to build ...
3 years, 9 months ago (2017-03-14 15:01:53 UTC) #1
Nico
Bleh, I forgot that external folks use this script too. agrieve, can we just revert ...
3 years, 9 months ago (2017-03-14 15:04:31 UTC) #2
agrieve
On 2017/03/14 15:04:31, Nico wrote: > Bleh, I forgot that external folks use this script ...
3 years, 9 months ago (2017-03-14 15:46:09 UTC) #3
Alexander Potapenko
On 2017/03/14 15:04:31, Nico wrote: > Bleh, I forgot that external folks use this script ...
3 years, 9 months ago (2017-03-14 16:55:21 UTC) #4
Derek Schuff
3 years, 9 months ago (2017-03-14 19:05:20 UTC) #5
On 2017/03/14 16:55:21, Alexander Potapenko wrote:
> On 2017/03/14 15:04:31, Nico wrote:
> > Bleh, I forgot that external folks use this script too.
> Perhaps it is worth a comment at the top of the file? :)
> > agrieve, can we just revert your patch that downloads this unconditionally?
> > krasin's actively working on moving the linux official build to lld, and
once
> > that's done we won't need this file at all anymore.
> 
> Thanks!

Just an extra +1. We use this for WebAssembly toolchain waterfalls too,  and on
my plate today was going to be figuring out how to work around and/or add this
same option. So thanks!

Powered by Google App Engine
This is Rietveld 408576698