Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2733043002:
Remove depenedency on GYP_DEFINES in clang gclient hook (Closed)
|
Created:
3 years, 9 months ago by agrieve Modified:
3 years, 9 months ago CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove dependency on GYP_DEFINES in clang gclient hook
The gold plugin is needed only for linux official builds. However, since
it's only 17MB, it's better to always download it rather than having it
depend on GYP_DEFINES.
BUG=570091, 699210
Review-Url: https://codereview.chromium.org/2733043002
Cr-Commit-Position: refs/heads/master@{#455991}
Committed: https://chromium.googlesource.com/chromium/src/+/57310cedbe5d558ba806b3f60f752b84e20a65eb
Patch Set 1 #Patch Set 2 : tweak comment #
Depends on Patchset: Messages
Total messages: 22 (11 generated)
Description was changed from ========== Remove depenedency on GYP_DEFINES in clang gclient hook The gold plugin is needed only for linux official builds. However, since it's only 17MB, it's better to always download it rather than having it depend on GYP_DEFINES. ========== to ========== Remove depenedency on GYP_DEFINES in clang gclient hook The gold plugin is needed only for linux official builds. However, since it's only 17MB, it's better to always download it rather than having it depend on GYP_DEFINES. ==========
agrieve@chromium.org changed reviewers: + thakis@chromium.org
On 2017/03/08 01:57:33, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:thakis@chromium.org
thakis@chromium.org changed reviewers: + krasin@chromium.org
krasin, do you think we'll move to lld for LTO soon? I.e. see https://bugs.chromium.org/p/chromium/issues/detail?id=679135 If lld is a bit out, then I think this is fine (change the comment to just say "needed for LTO in official builds" or something like that). If lld is happening soon, I'd rather we do that switch first.
On 2017/03/08 02:15:05, Nico wrote: > krasin, do you think we'll move to lld for LTO soon? I.e. see > https://bugs.chromium.org/p/chromium/issues/detail?id=679135 > > If lld is a bit out, then I think this is fine (change the comment to just say > "needed for LTO in official builds" or something like that). If lld is happening > soon, I'd rather we do that switch first. I would like to avoid switching to LLD before we switched to ThinLTO (most likely, these two will be combined, as ThinLTO ToT bot is running with LLD). The reason is that FullLTO is very slow, and LLD is even slower then Gold plugin, so a premature switch would cost a lot of engineering time without any particular benefits, while generating a real regression for desktop build times.
lgtm
but might want to include some BUG= line (maybe 570091 or maybe you have your own bug for hunting down GYP_DEFINES)
On 2017/03/08 18:17:27, Nico wrote: > but might want to include some BUG= line (maybe 570091 or maybe you have your > own bug for hunting down GYP_DEFINES) and add 699210 too
Description was changed from ========== Remove depenedency on GYP_DEFINES in clang gclient hook The gold plugin is needed only for linux official builds. However, since it's only 17MB, it's better to always download it rather than having it depend on GYP_DEFINES. ========== to ========== Remove depenedency on GYP_DEFINES in clang gclient hook The gold plugin is needed only for linux official builds. However, since it's only 17MB, it's better to always download it rather than having it depend on GYP_DEFINES. BUG=570091 ==========
Description was changed from ========== Remove depenedency on GYP_DEFINES in clang gclient hook The gold plugin is needed only for linux official builds. However, since it's only 17MB, it's better to always download it rather than having it depend on GYP_DEFINES. BUG=570091 ========== to ========== Remove dependency on GYP_DEFINES in clang gclient hook The gold plugin is needed only for linux official builds. However, since it's only 17MB, it's better to always download it rather than having it depend on GYP_DEFINES. BUG=570091 ==========
Description was changed from ========== Remove dependency on GYP_DEFINES in clang gclient hook The gold plugin is needed only for linux official builds. However, since it's only 17MB, it's better to always download it rather than having it depend on GYP_DEFINES. BUG=570091 ========== to ========== Remove dependency on GYP_DEFINES in clang gclient hook The gold plugin is needed only for linux official builds. However, since it's only 17MB, it's better to always download it rather than having it depend on GYP_DEFINES. BUG=570091, 699210 ==========
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489113134602990,
"parent_rev": "3c0495f5784b674f4ff0792da9a6d7c62815b565", "commit_rev":
"57310cedbe5d558ba806b3f60f752b84e20a65eb"}
Message was sent while issue was closed.
Description was changed from ========== Remove dependency on GYP_DEFINES in clang gclient hook The gold plugin is needed only for linux official builds. However, since it's only 17MB, it's better to always download it rather than having it depend on GYP_DEFINES. BUG=570091, 699210 ========== to ========== Remove dependency on GYP_DEFINES in clang gclient hook The gold plugin is needed only for linux official builds. However, since it's only 17MB, it's better to always download it rather than having it depend on GYP_DEFINES. BUG=570091, 699210 Review-Url: https://codereview.chromium.org/2733043002 Cr-Commit-Position: refs/heads/master@{#455991} Committed: https://chromium.googlesource.com/chromium/src/+/57310cedbe5d558ba806b3f60f75... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/57310cedbe5d558ba806b3f60f75...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2748973003/ by agrieve@chromium.org. The reason for reverting is: update.py is used by non-chromium devs. See: https://codereview.chromium.org/2749003002/. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
