Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2748873003: Reland of Switching AudioOutputAuthorizationHandler from using AudioManager interface to AudioSystem one. (Closed)

Created:
3 years, 9 months ago by o1ka
Modified:
3 years, 9 months ago
CC:
chromium-reviews, creis+watch_chromium.org, posciak+watch_chromium.org, nasko+codewatch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org, Max Morin, ossu, audio-mojo-cl_google.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Switching AudioOutputAuthorizationHandler from using AudioManager interface to AudioSystem one. (patchset #1 id:1 of https://codereview.chromium.org/2696253004/ ) Reason for revert: Relanding the original CL after landing the work around (https://codereview.chromium.org/2738403002/) Original issue's description: > Revert of Switching AudioOutputAuthorizationHandler from using AudioManager interface to AudioSystem one. (patchset #2 id:20001 of https://codereview.chromium.org/2692203003/ ) > > Reason for revert: > Seems to break PPAPINaClPNaClTest.MediaStreamAudioTrack on Mac. > https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/13657 > > Original issue's description: > > Switching AudioOutputAuthorizationHandler from using AudioManager interface to AudioSystem one. > > > > BUG=672468 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > > > Review-Url: https://codereview.chromium.org/2692203003 > > Cr-Commit-Position: refs/heads/master@{#450939} > > Committed: https://chromium.googlesource.com/chromium/src/+/04ff52bb66284467ccb43d90800013b89ee8db75 > > TBR=tommi@chromium.org,guidou@chromium.org,avi@chromium.org,olka@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=672468 > > Review-Url: https://codereview.chromium.org/2696253004 > Cr-Commit-Position: refs/heads/master@{#450952} > Committed: https://chromium.googlesource.com/chromium/src/+/156ba9177eb266804d52f98c1e17033705645b5d TBR=tommi@chromium.org,guidou@chromium.org,avi@chromium.org,perkj@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=672468 Review-Url: https://codereview.chromium.org/2748873003 Cr-Commit-Position: refs/heads/master@{#456742} Committed: https://chromium.googlesource.com/chromium/src/+/a39bab40d833b265d8ea764001ec3f872c49b8d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -55 lines) Patch
M content/browser/renderer_host/media/audio_output_authorization_handler.h View 3 chunks +6 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/audio_output_authorization_handler.cc View 3 chunks +5 lines, -24 lines 0 comments Download
M content/browser/renderer_host/media/audio_output_authorization_handler_unittest.cc View 11 chunks +11 lines, -8 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host_unittest.cc View 4 chunks +7 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/audio_system.h View 1 chunk +16 lines, -1 line 0 comments Download
M media/audio/audio_system_impl.h View 1 chunk +6 lines, -0 lines 0 comments Download
M media/audio/audio_system_impl.cc View 3 chunks +34 lines, -1 line 0 comments Download
M media/audio/audio_system_impl_unittest.cc View 7 chunks +71 lines, -7 lines 0 comments Download
M media/audio/mock_audio_manager.h View 1 chunk +8 lines, -1 line 0 comments Download
M media/audio/mock_audio_manager.cc View 3 chunks +19 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
o1ka
3 years, 9 months ago (2017-03-14 15:21:14 UTC) #2
Created Reland of Switching AudioOutputAuthorizationHandler from using
AudioManager interface to AudioSystem one.

Powered by Google App Engine
This is Rietveld 408576698