Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2696253004: Revert of Switching AudioOutputAuthorizationHandler from using AudioManager interface to AudioSystem one. (Closed)

Created:
3 years, 10 months ago by perkj_chrome
Modified:
3 years, 10 months ago
CC:
chromium-reviews, creis+watch_chromium.org, posciak+watch_chromium.org, nasko+codewatch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org, Max Morin, ossu, audio-mojo-cl_google.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Switching AudioOutputAuthorizationHandler from using AudioManager interface to AudioSystem one. (patchset #2 id:20001 of https://codereview.chromium.org/2692203003/ ) Reason for revert: Seems to break PPAPINaClPNaClTest.MediaStreamAudioTrack on Mac. https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/13657 Original issue's description: > Switching AudioOutputAuthorizationHandler from using AudioManager interface to AudioSystem one. > > BUG=672468 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2692203003 > Cr-Commit-Position: refs/heads/master@{#450939} > Committed: https://chromium.googlesource.com/chromium/src/+/04ff52bb66284467ccb43d90800013b89ee8db75 TBR=tommi@chromium.org,guidou@chromium.org,avi@chromium.org,olka@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672468 Review-Url: https://codereview.chromium.org/2696253004 Cr-Commit-Position: refs/heads/master@{#450952} Committed: https://chromium.googlesource.com/chromium/src/+/156ba9177eb266804d52f98c1e17033705645b5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -189 lines) Patch
M content/browser/renderer_host/media/audio_output_authorization_handler.h View 3 chunks +3 lines, -6 lines 0 comments Download
M content/browser/renderer_host/media/audio_output_authorization_handler.cc View 3 chunks +24 lines, -5 lines 0 comments Download
M content/browser/renderer_host/media/audio_output_authorization_handler_unittest.cc View 11 chunks +8 lines, -11 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host_unittest.cc View 4 chunks +1 line, -7 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/audio_system.h View 1 chunk +1 line, -16 lines 0 comments Download
M media/audio/audio_system_impl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M media/audio/audio_system_impl.cc View 3 chunks +1 line, -34 lines 0 comments Download
M media/audio/audio_system_impl_unittest.cc View 7 chunks +7 lines, -71 lines 0 comments Download
M media/audio/mock_audio_manager.h View 1 chunk +1 line, -8 lines 0 comments Download
M media/audio/mock_audio_manager.cc View 3 chunks +6 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
perkj_chrome
Created Revert of Switching AudioOutputAuthorizationHandler from using AudioManager interface to AudioSystem one.
3 years, 10 months ago (2017-02-16 14:20:59 UTC) #2
o1ka
3 years, 9 months ago (2017-03-14 15:21:13 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2748873003/ by olka@chromium.org.

The reason for reverting is: Relanding the original CL after landing the work
around (https://codereview.chromium.org/2738403002/).

Powered by Google App Engine
This is Rietveld 408576698