Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Unified Diff: media/audio/audio_system.h

Issue 2748873003: Reland of Switching AudioOutputAuthorizationHandler from using AudioManager interface to AudioSystem one. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | media/audio/audio_system_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_system.h
diff --git a/media/audio/audio_system.h b/media/audio/audio_system.h
index a11b030c742ab22e6b195f2a40388decd7df488c..76319cc2eb75aa1f84c513f030ce9f6729c9e872 100644
--- a/media/audio/audio_system.h
+++ b/media/audio/audio_system.h
@@ -25,8 +25,23 @@
virtual ~AudioSystem();
- // Callback will receive invalid parameters if the device is not found.
+ // Callback may receive invalid parameters, it means the specified device is
+ // not found. This is best-effort: valid parameters do not guarantee existance
+ // of the device.
+ // TODO(olka,tommi): fix all AudioManager implementations to return invalid
+ // parameters if the device is not found.
virtual void GetInputStreamParameters(
+ const std::string& device_id,
+ OnAudioParamsCallback on_params_cb) const = 0;
+
+ // If media::AudioDeviceDescription::IsDefaultDevice(device_id) is true,
+ // callback will receive the parameters of the default output device.
+ // Callback may receive invalid parameters, it means the specified device is
+ // not found. This is best-effort: valid parameters do not guarantee existance
+ // of the device.
+ // TODO(olka,tommi): fix all AudioManager implementations to return invalid
+ // parameters if the device is not found.
+ virtual void GetOutputStreamParameters(
const std::string& device_id,
OnAudioParamsCallback on_params_cb) const = 0;
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | media/audio/audio_system_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698