Linux UI: Dynamically respond to changes in the scale factor

Linux UI: Dynamically respond to changes in the scale factor

BUG=714309
R=erg@chromium.org
TBR=sky@chromium.org
CC=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2963033002
Cr-Commit-Position: refs/heads/master@{#483625}
Committed: https://chromium.googlesource.com/chromium/src/+/4313334bead373b139eee72f47d43fbe6162a8f4

[Tom Anderson, 2017-06-28 21:46:30]

Patchset #1 (id:1) has been deleted

[Tom Anderson, 2017-06-28 21:52:59]

erg ptal

But there's an issue with the CL as-is.  Please see this vid:
https://bugs.chromium.org/p/chromium/issues/detail?id=714309#c1
Know how to fix this?

[Elliot Glaysher, 2017-06-28 22:03:41]

are you getting the signal from gtk immediately or when you interact with the
window again?

if you're getting it immediately, are your forcing a repaint? perhaps everything
internal has updated, but hasn't redrawn itself?

[Tom Anderson, 2017-06-28 22:09:34]

On 2017/06/28 22:03:41, Elliot Glaysher wrote:
> are you getting the signal from gtk immediately or when you interact with the
> window again?

immediately

> if you're getting it immediately, are your forcing a repaint? 

Ok, I'll give it a try.  I thought that might not work because parts of the
window still get redrawn (eg when scrolling)

> perhaps everything
> internal has updated, but hasn't redrawn itself?

[Tom Anderson, 2017-06-28 22:10:01]

Description was changed from

==========
Linux UI: Dynamically to changes in the scale factor

BUG=714309
R=erg@chromium.org
CC=oshima@chromium.org
==========

to

==========
Linux UI: Respond dynamically to changes in the scale factor

BUG=714309
R=erg@chromium.org
CC=oshima@chromium.org
==========

[Tom Anderson, 2017-06-28 22:10:20]

Description was changed from

==========
Linux UI: Respond dynamically to changes in the scale factor

BUG=714309
R=erg@chromium.org
CC=oshima@chromium.org
==========

to

==========
Linux UI: Dynamically respond to changes in the scale factor

BUG=714309
R=erg@chromium.org
CC=oshima@chromium.org
==========

[Tom Anderson, 2017-06-29 00:17:43]

On 2017/06/28 22:09:34, Tom Anderson wrote:
> On 2017/06/28 22:03:41, Elliot Glaysher wrote:
> > are you getting the signal from gtk immediately or when you interact with
the
> > window again?
> 
> immediately
> 
> > if you're getting it immediately, are your forcing a repaint? 
> 
> Ok, I'll give it a try.  I thought that might not work because parts of the
> window still get redrawn (eg when scrolling)
> 
> > perhaps everything
> > internal has updated, but hasn't redrawn itself?

Ok, well I fixed it.  Basically I just ran the same code that runs when the
window gets resized externally.  For some reason, Relayout() and scheduling a
redraw on the compositor didn't do it.  Worth investigating further?

[Tom Anderson, 2017-06-29 00:19:51]

Patchset #2 (id:40001) has been deleted

[Elliot Glaysher, 2017-06-29 17:22:36]

That's a little weird; I think that's your call whether you want to dig deeper
or not.

anyway, lgtm

https://codereview.chromium.org/2963033002/diff/60001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/desktop_screen_x11.h (right):

https://codereview.chromium.org/2963033002/diff/60001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_screen_x11.h:78: void
UpdateDisplayConfiguration();
docs please.

[Tom Anderson, 2017-06-29 18:38:59]

On 2017/06/29 17:22:36, Elliot Glaysher wrote:
> That's a little weird; I think that's your call whether you want to dig deeper
> or not.

I added a comment acknowledging that it's weird and a TODO that it should be
changed (so people don't try to maintain bad code :)

I'll rebase/land this once that other guy's cl lands

https://codereview.chromium.org/2963033002/diff/60001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/desktop_screen_x11.h (right):

https://codereview.chromium.org/2963033002/diff/60001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_screen_x11.h:78: void
UpdateDisplayConfiguration();
On 2017/06/29 17:22:36, Elliot Glaysher wrote:
> docs please.

Done.

[Tom Anderson, 2017-06-29 22:04:10]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 22:04:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Anderson, 2017-06-29 23:01:48]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 23:02:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 23:50:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 23:50:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Tom Anderson, 2017-06-30 00:50:18]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 00:50:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 01:43:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 01:43:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Tom Anderson, 2017-06-30 01:54:17]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 01:54:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 03:10:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 03:10:37]

Dry run: This issue passed the CQ dry run.

[Tom (Use chromium acct), 2017-06-30 03:29:36]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2017-06-30 03:29:36]

The patchset sent to the CQ was uploaded after l-g-t-m from erg@chromium.org
Link to the patchset: https://codereview.chromium.org/2963033002/#ps140001
(title: "LinuxUI may not exist in test scenarios")

[commit-bot: I haz the power, 2017-06-30 03:29:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 03:37:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 03:37:53]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Tom Anderson, 2017-06-30 03:50:29]

thomasanderson@chromium.org changed reviewers:
- thomasanderson@google.com

[Tom Anderson, 2017-06-30 03:51:31]

Description was changed from

==========
Linux UI: Dynamically respond to changes in the scale factor

BUG=714309
R=erg@chromium.org
CC=oshima@chromium.org
==========

to

==========
Linux UI: Dynamically respond to changes in the scale factor

BUG=714309
R=erg@chromium.org
TBR=sky@chromium.org
CC=oshima@chromium.org
==========

[Tom Anderson, 2017-06-30 03:52:21]

thomasanderson@chromium.org changed reviewers:
+ sky@chromium.org

[Tom Anderson, 2017-06-30 03:52:22]

TBR'ing sky for rename change in ui/views/test/desktop_screen_x11_test_api.cc

[Tom Anderson, 2017-06-30 03:52:27]

The CQ bit was checked by thomasanderson@chromium.org

[commit-bot: I haz the power, 2017-06-30 03:52:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 03:56:33]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1498794747939080,
"parent_rev": "3a0793ae0128c73d8731ee5b0c8434fe4980b6cf", "commit_rev":
"4313334bead373b139eee72f47d43fbe6162a8f4"}

[commit-bot: I haz the power, 2017-06-30 03:56:48]

Description was changed from

==========
Linux UI: Dynamically respond to changes in the scale factor

BUG=714309
R=erg@chromium.org
TBR=sky@chromium.org
CC=oshima@chromium.org
==========

to

==========
Linux UI: Dynamically respond to changes in the scale factor

BUG=714309
R=erg@chromium.org
TBR=sky@chromium.org
CC=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2963033002
Cr-Commit-Position: refs/heads/master@{#483625}
Committed:
https://chromium.googlesource.com/chromium/src/+/4313334bead373b139eee72f47d4...
==========

[commit-bot: I haz the power, 2017-06-30 03:56:49]

Committed patchset #6 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/4313334bead373b139eee72f47d4...