Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2747783004: [ia32] Supplement shift instructions for SIMD (Closed)

Created:
3 years, 9 months ago by Jing
Modified:
3 years, 9 months ago
Reviewers:
Benedikt Meurer, bbudge
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ia32] Supplement shift instructions for SIMD psll/rl/raw(xmm, imm) psrad(xmm, imm) vpsll/rl/raw(xmm, xmm, imm) vpsll/rl/rad(xmm, xmm, imm) BUG= Review-Url: https://codereview.chromium.org/2747783004 Cr-Commit-Position: refs/heads/master@{#43762} Committed: https://chromium.googlesource.com/v8/v8/+/97254b0d23d41a4705f7ecdcfc3dfb6448cd10a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -8 lines) Patch
M src/ia32/assembler-ia32.h View 2 chunks +11 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 5 chunks +68 lines, -1 line 0 comments Download
M src/ia32/disasm-ia32.cc View 4 chunks +24 lines, -6 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 3 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Jing
3 years, 9 months ago (2017-03-14 07:23:59 UTC) #2
Benedikt Meurer
lgtm
3 years, 9 months ago (2017-03-14 07:48:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747783004/1
3 years, 9 months ago (2017-03-14 07:58:00 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 08:01:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/97254b0d23d41a4705f7ecdcfc3dfb6448c...

Powered by Google App Engine
This is Rietveld 408576698