Remove unused methods in webkitpy cpp style checker and test.

Remove unused methods in webkitpy cpp style checker and test.

BUG=677561
Review-Url: https://codereview.chromium.org/2747643002
Cr-Commit-Position: refs/heads/master@{#456745}
Committed: https://chromium.googlesource.com/chromium/src/+/1fe686d9554038284aa9a3e5da5e2f7d519859ac

[qyearsley, 2017-03-13 16:23:45]

qyearsley@chromium.org changed reviewers:
+ dcheng@chromium.org

[qyearsley, 2017-03-14 02:57:05]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 02:57:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 03:00:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 03:00:14]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dcheng, 2017-03-14 04:45:54]

https://codereview.chromium.org/2747643002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
(right):

https://codereview.chromium.org/2747643002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:613: 
Why does this need an empty tearDownClass?

[qyearsley, 2017-03-14 16:08:12]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 16:09:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2017-03-14 16:11:00]

https://codereview.chromium.org/2747643002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
(right):

https://codereview.chromium.org/2747643002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:613: 
On 2017/03/14 at 04:45:54, dcheng wrote:
> Why does this need an empty tearDownClass?

It doesn't, thanks for pointing this out :-)

When I was removing verify_all_categories_are_seen (which is unused), I was
thinking that maybe instead it would be better to call it once in tearDownClass.
But if we want to do this, then another change has to be made; all test methods
must be changed to use the same ErrorCollector object.

Then I thought, since this isn't used now and it adds complexity, maybe it's
better to just remove it. What do you think?

[dcheng, 2017-03-14 16:28:56]

LGTM

(Yeah, easy enough to add this back when it's needed)

[qyearsley, 2017-03-14 16:30:21]

The CQ bit was unchecked by qyearsley@chromium.org

[qyearsley, 2017-03-14 16:30:23]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2017-03-14 16:30:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 17:15:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489509023215980,
"parent_rev": "18b8670fe8e1dcbe4955cbb47682b653fddd9ecc", "commit_rev":
"1fe686d9554038284aa9a3e5da5e2f7d519859ac"}

[commit-bot: I haz the power, 2017-03-14 17:16:25]

Description was changed from

==========
Remove unused methods in webkitpy cpp style checker and test.

BUG=677561
==========

to

==========
Remove unused methods in webkitpy cpp style checker and test.

BUG=677561

Review-Url: https://codereview.chromium.org/2747643002
Cr-Commit-Position: refs/heads/master@{#456745}
Committed:
https://chromium.googlesource.com/chromium/src/+/1fe686d9554038284aa9a3e5da5e...
==========

[commit-bot: I haz the power, 2017-03-14 17:16:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1fe686d9554038284aa9a3e5da5e...