Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2747643002: Remove unused methods in webkitpy cpp style checker and test. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
dcheng
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused methods in webkitpy cpp style checker and test. BUG=677561 Review-Url: https://codereview.chromium.org/2747643002 Cr-Commit-Position: refs/heads/master@{#456745} Committed: https://chromium.googlesource.com/chromium/src/+/1fe686d9554038284aa9a3e5da5e2f7d519859ac

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove empty tearDownClass #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -36 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py View 1 3 chunks +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py View 1 5 chunks +2 lines, -22 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
qyearsley
3 years, 9 months ago (2017-03-13 16:23:46 UTC) #2
dcheng
https://codereview.chromium.org/2747643002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py File third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (right): https://codereview.chromium.org/2747643002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py#newcode613 third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:613: Why does this need an empty tearDownClass?
3 years, 9 months ago (2017-03-14 04:45:54 UTC) #7
qyearsley
https://codereview.chromium.org/2747643002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py File third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (right): https://codereview.chromium.org/2747643002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py#newcode613 third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:613: On 2017/03/14 at 04:45:54, dcheng wrote: > Why does ...
3 years, 9 months ago (2017-03-14 16:11:00 UTC) #10
dcheng
LGTM (Yeah, easy enough to add this back when it's needed)
3 years, 9 months ago (2017-03-14 16:28:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747643002/20001
3 years, 9 months ago (2017-03-14 16:30:30 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 17:16:26 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1fe686d9554038284aa9a3e5da5e...

Powered by Google App Engine
This is Rietveld 408576698