Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py

Issue 2747643002: Remove unused methods in webkitpy cpp style checker and test. (Closed)
Patch Set: Remove empty tearDownClass Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py b/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py
index 29fa5236573596c6917fd72b20b9b03db62dcd6a..e020141ef4380979b76e28834c4ea5c6e51eba30 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py
@@ -1200,7 +1200,6 @@ class _ClassState(object):
class _FileState(object):
def __init__(self, clean_lines, file_extension):
- self._did_inside_namespace_indent_warning = False
self._clean_lines = clean_lines
if file_extension in ['m', 'mm']:
self._is_objective_c = True
@@ -1218,12 +1217,6 @@ class _FileState(object):
self._is_objective_c = False
self._is_c = False
- def set_did_inside_namespace_indent_warning(self):
- self._did_inside_namespace_indent_warning = True
-
- def did_inside_namespace_indent_warning(self):
- return self._did_inside_namespace_indent_warning
-
def is_objective_c(self):
if self._is_objective_c is None:
for line in self._clean_lines.elided:
@@ -1823,13 +1816,6 @@ def check_enum_casing(clean_lines, line_number, enum_state, error):
'enum members should use InterCaps with an initial capital letter.')
-def get_initial_spaces_for_line(clean_line):
- initial_spaces = 0
- while initial_spaces < len(clean_line) and clean_line[initial_spaces] == ' ':
- initial_spaces += 1
- return initial_spaces
-
-
def check_using_std(clean_lines, line_number, file_state, error):
"""Looks for 'using std::foo;' statements which should be replaced with 'using namespace std;'.
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698