Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1383)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py

Issue 2747643002: Remove unused methods in webkitpy cpp style checker and test. (Closed)
Patch Set: Remove empty tearDownClass Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
index 7880bef137ef0d447be6e95a1f00843951d0b036..8aab0eeace03626e301010de1866bcfe69330a93 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
@@ -50,10 +50,7 @@ from webkitpy.style.filter import FilterConfiguration
# is in STYLE_CATEGORIES, to help keep that list up to date.
-class ErrorCollector:
- _all_style_categories = CppChecker.categories
- # This is a list including all categories seen in any unit test.
- _seen_style_categories = {}
+class ErrorCollector(object):
def __init__(self, assert_fn, filter=None, lines_to_check=None):
"""assert_fn: a function to call when we notice a problem.
@@ -62,6 +59,7 @@ class ErrorCollector:
self._assert_fn = assert_fn
self._errors = []
self._lines_to_check = lines_to_check
+ self._all_style_categories = CppChecker.categories
if not filter:
filter = FilterConfiguration()
self._filter = filter
@@ -75,7 +73,6 @@ class ErrorCollector:
return False
if self._filter.should_check(category, ''):
- self._seen_style_categories[category] = 1
self._errors.append('%s [%s] [%d]' % (message, category, confidence))
return True
@@ -88,20 +85,6 @@ class ErrorCollector:
def result_list(self):
return self._errors
- def verify_all_categories_are_seen(self):
- """Fails if there's a category in _all_style_categories - _seen_style_categories.
-
- This should only be called after all tests are run, so
- _seen_style_categories has had a chance to fully populate. Since
- this isn't called from within the normal unittest framework, we
- can't use the normal unittest assert macros. Instead we just exit
- when we see an error. Good thing this test is always run last!
- """
- for category in self._all_style_categories:
- if category not in self._seen_style_categories:
- import sys
- sys.exit('FATAL ERROR: There are no tests for category "%s"' % category)
-
class CppFunctionsTest(unittest.TestCase):
@@ -2542,9 +2525,6 @@ class CheckForFunctionLengthsTest(CppStyleTestBase):
def function_body(self, number_of_lines):
return ' {\n' + ' this_is_just_a_test();\n' * number_of_lines + '}'
- def function_body_with_blank_lines(self, number_of_lines):
- return ' {\n' + ' this_is_just_a_test();\n\n' * number_of_lines + '}'
-
def function_body_with_no_lints(self, number_of_lines):
return ' {\n' + ' this_is_just_a_test(); // NOLINT\n' * number_of_lines + '}'
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698