DM: duh, don't calculate digests unless we're going to look at them.

DM: duh, don't calculate digests unless we're going to look at them.

This doesn't cut the runtime significantly (~6s either way) but it does cut the CPU time down from ~10s to ~6s.

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=11826

[bungeman-skia, 2013-10-16 17:22:54]

lgtm

https://codereview.chromium.org/27476007/diff/1/dm/DMReplayTask.cpp
File dm/DMReplayTask.cpp (right):

https://codereview.chromium.org/27476007/diff/1/dm/DMReplayTask.cpp#newcode39
dm/DMReplayTask.cpp:39: 0 != memcmp(bitmap.getPixels(), fReference.getPixels(),
bitmap.getSize())) {
I know it isn't technically in the skia style guide, and may even be against it,
but I like the '{' to go on the next line for tests that span multiple lines
like this.

[mtklein, 2013-10-16 17:27:47]

https://codereview.chromium.org/27476007/diff/1/dm/DMReplayTask.cpp
File dm/DMReplayTask.cpp (right):

https://codereview.chromium.org/27476007/diff/1/dm/DMReplayTask.cpp#newcode39
dm/DMReplayTask.cpp:39: 0 != memcmp(bitmap.getPixels(), fReference.getPixels(),
bitmap.getSize())) {
On 2013/10/16 17:22:54, bungeman1 wrote:
> I know it isn't technically in the skia style guide, and may even be against
it,
> but I like the '{' to go on the next line for tests that span multiple lines
> like this. 

Done.

[commit-bot: I haz the power, 2013-10-16 18:30:29]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/mtklein@google.com/27476007/9001

[commit-bot: I haz the power, 2013-10-16 19:13:42]

Change committed as 11826

[epoger, 2013-10-17 16:14:01]

https://codereview.chromium.org/27476007/diff/9001/dm/DMReplayTask.h
File dm/DMReplayTask.h (right):

https://codereview.chromium.org/27476007/diff/9001/dm/DMReplayTask.h#newcode13
dm/DMReplayTask.h:13: // Records a GM through an SkPicture, draws it, and
compares against the reference bitmap.
The question is, will DM have the reference bitmap to compare against?  Or will
it be comparing against a checksum?

On Android, we typically want to compare against a checksum (i.e. image hash). 
Otherwise, we have to copy all the reference images down to the device where you
are rendering the test images.  It's much faster to just copy down the
checksums.

[mtklein, 2013-10-17 16:34:06]

On 2013/10/17 16:14:01, epoger wrote:
> https://codereview.chromium.org/27476007/diff/9001/dm/DMReplayTask.h
> File dm/DMReplayTask.h (right):
> 
> https://codereview.chromium.org/27476007/diff/9001/dm/DMReplayTask.h#newcode13
> dm/DMReplayTask.h:13: // Records a GM through an SkPicture, draws it, and
> compares against the reference bitmap.
> The question is, will DM have the reference bitmap to compare against?  Or
will
> it be comparing against a checksum?
> 
> On Android, we typically want to compare against a checksum (i.e. image hash).

> Otherwise, we have to copy all the reference images down to the device where
you
> are rendering the test images.  It's much faster to just copy down the
> checksums.

Yes, the reference bitmap will always exist here.  We'll always be looking at
two freshly-minted in-memory bitmaps: the one ReplayTask just finished drawing,
and the one the corresponding CpuTask drew as the reference.  That reference
bitmap in turn is what we compare with a checksum, if given.  DM will definitely
always support---and indeed currently only supports---checksum expectations.