dm/DMComparisonTask.cpp - Issue 27476007: DM: duh, don't calculate digests unless we're going to look at them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/DMComparisonTask.cpp

Issue 27476007: DM: duh, don't calculate digests unless we're going to look at them. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: sync and merge Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dm/DMComparisonTask.cpp

diff --git a/dm/DMComparisonTask.cpp b/dm/DMComparisonTask.cpp

index f4f742c921077da558e0cad60cc6ea5569fcd0c1..24976f011dcf98cffe4fac029a43c1d2f22488e3 100644

--- a/dm/DMComparisonTask.cpp

+++ b/dm/DMComparisonTask.cpp

@@ -13,8 +13,7 @@ ComparisonTask::ComparisonTask(const Task& parent,

{}

void ComparisonTask::draw() {

- const skiagm::GmResultDigest digest(fBitmap);

- if (!meetsExpectations(fExpectations, digest)) {

+ if (!meetsExpectations(fExpectations, fBitmap)) {

this->fail();

}

« no previous file with comments | « no previous file | dm/DMCpuTask.cpp » ('j') | dm/DMReplayTask.h » ('J')