Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2747423003:
Disable flaky tests (Closed)
|
Created:
3 years, 9 months ago by oka Modified:
3 years, 9 months ago Reviewers:
fukino CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, davemoore+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable flaky tests
BUG=699426, 701922, 701923
TEST=None
Review-Url: https://codereview.chromium.org/2747423003
Cr-Commit-Position: refs/heads/master@{#457390}
Committed: https://chromium.googlesource.com/chromium/src/+/a98e9b6fd8c5a7b05e519c512383d039188eac17
Patch Set 1 #
Total comments: 1
Messages
Total messages: 16 (9 generated)
The CQ bit was checked by oka@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
oka@chromium.org changed reviewers: + fukino@chromium.org
PTAL.
Description was changed from ========== Disabled flaky tests BUG=699426,701922,701923 TEST=None ========== to ========== Disable flaky tests BUG=699426,701922,701923 TEST=None ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fukino@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1489658705694850, "parent_rev":
"2330dd65e77ba1724e43ced81ef36efae9e4d814", "commit_rev":
"a98e9b6fd8c5a7b05e519c512383d039188eac17"}
Message was sent while issue was closed.
Description was changed from ========== Disable flaky tests BUG=699426,701922,701923 TEST=None ========== to ========== Disable flaky tests BUG=699426,701922,701923 TEST=None Review-Url: https://codereview.chromium.org/2747423003 Cr-Commit-Position: refs/heads/master@{#457390} Committed: https://chromium.googlesource.com/chromium/src/+/a98e9b6fd8c5a7b05e519c512383... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a98e9b6fd8c5a7b05e519c512383...
Message was sent while issue was closed.
https://codereview.chromium.org/2747423003/diff/1/chrome/browser/chromeos/fil... File chrome/browser/chromeos/file_manager/file_manager_browsertest.cc (right): https://codereview.chromium.org/2747423003/diff/1/chrome/browser/chromeos/fil... chrome/browser/chromeos/file_manager/file_manager_browsertest.cc:348: DISABLE_SuggestAppDialog, It seems the prefix should be DISABLED. Missing a "D" in the end. The test is still running on Waterfall https://luci-milo.appspot.com/buildbot/chromium.chromiumos/Linux%20ChromiumOS...
Message was sent while issue was closed.
Oops, I overlooked the typo. oka@, DISABLE_ should be DISABLED_ ...
Message was sent while issue was closed.
On 2017/03/21 03:49:21, fukino wrote: > Oops, I overlooked the typo. > oka@, DISABLE_ should be DISABLED_ ... Sent https://codereview.chromium.org/2764783002/ |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
