Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Side by Side Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Issue 2747423003: Disable flaky tests (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/browser/chromeos/drive/file_system_util.h" 9 #include "chrome/browser/chromeos/drive/file_system_util.h"
10 #include "chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h" 10 #include "chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h"
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 MAYBE_OpenAudioFiles, 105 MAYBE_OpenAudioFiles,
106 FileManagerBrowserTest, 106 FileManagerBrowserTest,
107 ::testing::Values( 107 ::testing::Values(
108 TestParameter(IN_GUEST_MODE, "audioOpenDownloads"), 108 TestParameter(IN_GUEST_MODE, "audioOpenDownloads"),
109 TestParameter(NOT_IN_GUEST_MODE, "audioOpenDownloads"), 109 TestParameter(NOT_IN_GUEST_MODE, "audioOpenDownloads"),
110 TestParameter(NOT_IN_GUEST_MODE, "audioOpenDrive"), 110 TestParameter(NOT_IN_GUEST_MODE, "audioOpenDrive"),
111 TestParameter(NOT_IN_GUEST_MODE, "audioAutoAdvanceDrive"), 111 TestParameter(NOT_IN_GUEST_MODE, "audioAutoAdvanceDrive"),
112 TestParameter(NOT_IN_GUEST_MODE, "audioRepeatAllModeSingleFileDrive"), 112 TestParameter(NOT_IN_GUEST_MODE, "audioRepeatAllModeSingleFileDrive"),
113 TestParameter(NOT_IN_GUEST_MODE, "audioNoRepeatModeSingleFileDrive"), 113 TestParameter(NOT_IN_GUEST_MODE, "audioNoRepeatModeSingleFileDrive"),
114 TestParameter(NOT_IN_GUEST_MODE, "audioRepeatOneModeSingleFileDrive"), 114 TestParameter(NOT_IN_GUEST_MODE, "audioRepeatOneModeSingleFileDrive"),
115 TestParameter(NOT_IN_GUEST_MODE, "audioRepeatAllModeMultipleFileDrive"), 115 // TODO(crbug.com/701922) Revive this flaky test.
116 // TestParameter(NOT_IN_GUEST_MODE,
117 // "audioRepeatAllModeMultipleFileDrive"),
116 TestParameter(NOT_IN_GUEST_MODE, "audioNoRepeatModeMultipleFileDrive"), 118 TestParameter(NOT_IN_GUEST_MODE, "audioNoRepeatModeMultipleFileDrive"),
117 TestParameter(NOT_IN_GUEST_MODE, 119 TestParameter(NOT_IN_GUEST_MODE,
118 "audioRepeatOneModeMultipleFileDrive"))); 120 "audioRepeatOneModeMultipleFileDrive")));
119 121
120 // Fails on official build. http://crbug.com/429294 122 // Fails on official build. http://crbug.com/429294
121 #if defined(DISABLE_SLOW_FILESAPP_TESTS) || defined(OFFICIAL_BUILD) 123 #if defined(DISABLE_SLOW_FILESAPP_TESTS) || defined(OFFICIAL_BUILD)
122 #define MAYBE_OpenImageFiles DISABLED_OpenImageFiles 124 #define MAYBE_OpenImageFiles DISABLED_OpenImageFiles
123 #else 125 #else
124 #define MAYBE_OpenImageFiles OpenImageFiles 126 #define MAYBE_OpenImageFiles OpenImageFiles
125 #endif 127 #endif
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 TestParameter(NOT_IN_GUEST_MODE, "renameFileDrive"), 170 TestParameter(NOT_IN_GUEST_MODE, "renameFileDrive"),
169 TestParameter(IN_GUEST_MODE, "renameNewDirectoryDownloads"), 171 TestParameter(IN_GUEST_MODE, "renameNewDirectoryDownloads"),
170 TestParameter(NOT_IN_GUEST_MODE, "renameNewDirectoryDownloads"), 172 TestParameter(NOT_IN_GUEST_MODE, "renameNewDirectoryDownloads"),
171 TestParameter(NOT_IN_GUEST_MODE, "renameNewDirectoryDrive"))); 173 TestParameter(NOT_IN_GUEST_MODE, "renameNewDirectoryDrive")));
172 174
173 #if defined(DISABLE_SLOW_FILESAPP_TESTS) 175 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
174 #define MAYBE_Delete DISABLED_Delete 176 #define MAYBE_Delete DISABLED_Delete
175 #else 177 #else
176 #define MAYBE_Delete Delete 178 #define MAYBE_Delete Delete
177 #endif 179 #endif
180 // Flaky: crbug.com/699426
178 WRAPPED_INSTANTIATE_TEST_CASE_P( 181 WRAPPED_INSTANTIATE_TEST_CASE_P(
179 MAYBE_Delete, 182 DISABLE_Delete,
180 FileManagerBrowserTest, 183 FileManagerBrowserTest,
181 ::testing::Values( 184 ::testing::Values(
182 TestParameter(NOT_IN_GUEST_MODE, 185 TestParameter(NOT_IN_GUEST_MODE,
183 "deleteMenuItemIsDisabledWhenNoItemIsSelected"), 186 "deleteMenuItemIsDisabledWhenNoItemIsSelected"),
184 TestParameter(NOT_IN_GUEST_MODE, "deleteOneItemFromToolbar"))); 187 TestParameter(NOT_IN_GUEST_MODE, "deleteOneItemFromToolbar")));
185 188
186 WRAPPED_INSTANTIATE_TEST_CASE_P( 189 WRAPPED_INSTANTIATE_TEST_CASE_P(
187 DISABLED_QuickView, 190 DISABLED_QuickView,
188 FileManagerBrowserTest, 191 FileManagerBrowserTest,
189 ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "openQuickView"))); 192 ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "openQuickView")));
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 FileManagerBrowserTest, 336 FileManagerBrowserTest,
334 ::testing::Values(TestParameter(IN_GUEST_MODE, "traverseDownloads"), 337 ::testing::Values(TestParameter(IN_GUEST_MODE, "traverseDownloads"),
335 TestParameter(NOT_IN_GUEST_MODE, "traverseDownloads"), 338 TestParameter(NOT_IN_GUEST_MODE, "traverseDownloads"),
336 TestParameter(NOT_IN_GUEST_MODE, "traverseDrive"))); 339 TestParameter(NOT_IN_GUEST_MODE, "traverseDrive")));
337 340
338 #if defined(DISABLE_SLOW_FILESAPP_TESTS) 341 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
339 #define MAYBE_SuggestAppDialog DISABLED_SuggestAppDialog 342 #define MAYBE_SuggestAppDialog DISABLED_SuggestAppDialog
340 #else 343 #else
341 #define MAYBE_SuggestAppDialog SuggestAppDialog 344 #define MAYBE_SuggestAppDialog SuggestAppDialog
342 #endif 345 #endif
346 // Flaky: crbug.com/701923
343 WRAPPED_INSTANTIATE_TEST_CASE_P( 347 WRAPPED_INSTANTIATE_TEST_CASE_P(
344 MAYBE_SuggestAppDialog, 348 DISABLE_SuggestAppDialog,
stgao 2017/03/17 17:32:21 It seems the prefix should be DISABLED. Missing a
345 FileManagerBrowserTest, 349 FileManagerBrowserTest,
346 ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "suggestAppDialog"))); 350 ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "suggestAppDialog")));
347 351
348 #if defined(DISABLE_SLOW_FILESAPP_TESTS) 352 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
349 #define MAYBE_ExecuteDefaultTaskOnDownloads \ 353 #define MAYBE_ExecuteDefaultTaskOnDownloads \
350 DISABLED_ExecuteDefaultTaskOnDownloads 354 DISABLED_ExecuteDefaultTaskOnDownloads
351 #else 355 #else
352 #define MAYBE_ExecuteDefaultTaskOnDownloads ExecuteDefaultTaskOnDownloads 356 #define MAYBE_ExecuteDefaultTaskOnDownloads ExecuteDefaultTaskOnDownloads
353 #endif 357 #endif
354 WRAPPED_INSTANTIATE_TEST_CASE_P( 358 WRAPPED_INSTANTIATE_TEST_CASE_P(
(...skipping 340 matching lines...) Expand 10 before | Expand all | Expand 10 after
695 699
696 IN_PROC_BROWSER_TEST_F(MultiProfileFileManagerBrowserTest, MAYBE_BasicDrive) { 700 IN_PROC_BROWSER_TEST_F(MultiProfileFileManagerBrowserTest, MAYBE_BasicDrive) {
697 AddAllUsers(); 701 AddAllUsers();
698 702
699 // Sanity check that normal operations work in multi-profile setting as well. 703 // Sanity check that normal operations work in multi-profile setting as well.
700 set_test_case_name("keyboardCopyDrive"); 704 set_test_case_name("keyboardCopyDrive");
701 StartTest(); 705 StartTest();
702 } 706 }
703 707
704 } // namespace file_manager 708 } // namespace file_manager
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698