Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1440)

Unified Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Issue 2747423003: Disable flaky tests (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
diff --git a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
index 5bf14b11f174e77635b151be204e8feb3f48a47e..18f3cfd6015ceb1aa3d48c7648a886b3eb332bdc 100644
--- a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
+++ b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
@@ -112,7 +112,9 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(
TestParameter(NOT_IN_GUEST_MODE, "audioRepeatAllModeSingleFileDrive"),
TestParameter(NOT_IN_GUEST_MODE, "audioNoRepeatModeSingleFileDrive"),
TestParameter(NOT_IN_GUEST_MODE, "audioRepeatOneModeSingleFileDrive"),
- TestParameter(NOT_IN_GUEST_MODE, "audioRepeatAllModeMultipleFileDrive"),
+ // TODO(crbug.com/701922) Revive this flaky test.
+ // TestParameter(NOT_IN_GUEST_MODE,
+ // "audioRepeatAllModeMultipleFileDrive"),
TestParameter(NOT_IN_GUEST_MODE, "audioNoRepeatModeMultipleFileDrive"),
TestParameter(NOT_IN_GUEST_MODE,
"audioRepeatOneModeMultipleFileDrive")));
@@ -175,8 +177,9 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(
#else
#define MAYBE_Delete Delete
#endif
+// Flaky: crbug.com/699426
WRAPPED_INSTANTIATE_TEST_CASE_P(
- MAYBE_Delete,
+ DISABLE_Delete,
FileManagerBrowserTest,
::testing::Values(
TestParameter(NOT_IN_GUEST_MODE,
@@ -340,8 +343,9 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(
#else
#define MAYBE_SuggestAppDialog SuggestAppDialog
#endif
+// Flaky: crbug.com/701923
WRAPPED_INSTANTIATE_TEST_CASE_P(
- MAYBE_SuggestAppDialog,
+ DISABLE_SuggestAppDialog,
stgao 2017/03/17 17:32:21 It seems the prefix should be DISABLED. Missing a
FileManagerBrowserTest,
::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "suggestAppDialog")));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698