Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2747103002: [ia32] Add minps/maxps and AVX v_ps/v_pd for add/sub/mul/div/min/max (Closed)

Created:
3 years, 9 months ago by Jing
Modified:
3 years, 9 months ago
Reviewers:
Benedikt Meurer, bbudge
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ia32] Add minps/maxps and AVX v_ps/v_pd for add/sub/mul/div/min/max Also use vinstr for vps/vpd/vss/vsd BUG= Review-Url: https://codereview.chromium.org/2747103002 Cr-Commit-Position: refs/heads/master@{#43809} Committed: https://chromium.googlesource.com/v8/v8/+/d598386db8d405ef3ed6217e1191f1404827c0c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -21 lines) Patch
M src/ia32/assembler-ia32.h View 2 chunks +12 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32.cc View 2 chunks +17 lines, -20 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 2 chunks +60 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Jing
3 years, 9 months ago (2017-03-14 12:29:29 UTC) #2
bbudge
lgtm
3 years, 9 months ago (2017-03-14 16:06:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747103002/1
3 years, 9 months ago (2017-03-15 01:59:26 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 02:01:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d598386db8d405ef3ed6217e1191f140482...

Powered by Google App Engine
This is Rietveld 408576698