Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2746873002: Revert of Move FrameHost::m_subframeCount to Page (Closed)

Created:
3 years, 9 months ago by yoichio
Modified:
3 years, 9 months ago
Reviewers:
haraken, sashab, joelhockey
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move FrameHost::m_subframeCount to Page (patchset #3 id:40001 of https://codereview.chromium.org/2739033003/ ) Reason for revert: Builders this step failed on: WebKit Linux Trusty Leak [2 since first detection] 2 tests failed: external/wpt/fullscreen/api/document-exit-fullscreen-nested-in-iframe-manual.html ( Code Search ) fast/forms/select/input-select-after-resize.html ( Code Search ) https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak Original issue's description: > Move FrameHost::m_subframeCount to Page > > Move the field FrameHost::m_subframeCount to Page, and update > FrameHost methods to directly call the equivalent Page method. > > BUG=691794 > > Review-Url: https://codereview.chromium.org/2739033003 > Cr-Commit-Position: refs/heads/master@{#456321} > Committed: https://chromium.googlesource.com/chromium/src/+/eb7ffe6561358b82498f885544ffdf50a5e46646 TBR=joelhockey@chromium.org,sashab@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=691794 Review-Url: https://codereview.chromium.org/2746873002 Cr-Commit-Position: refs/heads/master@{#456334} Committed: https://chromium.googlesource.com/chromium/src/+/214dd7fe513f8d06e76644c08db75fd8d3355d65

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -49 lines) Patch
M third_party/WebKit/Source/core/dom/NodeRareData.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.h View 2 chunks +12 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 2 chunks +16 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.h View 2 chunks +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 2 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
yoichio
Created Revert of Move FrameHost::m_subframeCount to Page
3 years, 9 months ago (2017-03-13 08:03:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746873002/1
3 years, 9 months ago (2017-03-13 08:03:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/214dd7fe513f8d06e76644c08db75fd8d3355d65
3 years, 9 months ago (2017-03-13 08:04:58 UTC) #6
haraken
3 years, 9 months ago (2017-03-13 10:38:17 UTC) #7
Message was sent while issue was closed.
LGTM (although I'm not sure if the CL is a real culprit.)

Powered by Google App Engine
This is Rietveld 408576698