Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 2746873002: Revert of Move FrameHost::m_subframeCount to Page (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/page/Page.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/page/Page.cpp
diff --git a/third_party/WebKit/Source/core/page/Page.cpp b/third_party/WebKit/Source/core/page/Page.cpp
index d8c2dfa769ffdfa66e2c35d5991748887a5ee653..0aa6889799c7803c12dd4efcd087669cca815225 100644
--- a/third_party/WebKit/Source/core/page/Page.cpp
+++ b/third_party/WebKit/Source/core/page/Page.cpp
@@ -120,7 +120,6 @@
m_deviceScaleFactor(1),
m_visibilityState(PageVisibilityStateVisible),
m_isCursorVisible(true),
- m_subframeCount(0),
m_frameHost(FrameHost::create(*this)) {
ASSERT(m_editorClient);
@@ -387,25 +386,6 @@
bool Page::isCursorVisible() const {
return m_isCursorVisible;
-}
-
-#if DCHECK_IS_ON()
-void checkFrameCountConsistency(int expectedFrameCount, Frame* frame) {
- DCHECK_GE(expectedFrameCount, 0);
-
- int actualFrameCount = 0;
- for (; frame; frame = frame->tree().traverseNext())
- ++actualFrameCount;
-
- DCHECK_EQ(expectedFrameCount, actualFrameCount);
-}
-#endif
-
-int Page::subframeCount() const {
-#if DCHECK_IS_ON()
- checkFrameCountConsistency(m_subframeCount + 1, mainFrame());
-#endif
- return m_subframeCount;
}
void Page::settingsChanged(SettingsDelegate::ChangeType changeType) {
« no previous file with comments | « third_party/WebKit/Source/core/page/Page.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698