third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp - Issue 2746873002: Revert of Move FrameHost::m_subframeCount to Page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

Issue 2746873002: Revert of Move FrameHost::m_subframeCount to Page (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

index 9aaebf4c7cfc65c1f309d1b527187eb9c5ab9933..0efebb766aca2cd98e06e3f806719037c619870d 100644

--- a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

@@ -33,7 +33,6 @@

#include "core/layout/api/LayoutPartItem.h"

#include "core/loader/FrameLoadRequest.h"

#include "core/loader/FrameLoader.h"

-#include "core/page/Page.h"

#include "core/plugins/PluginView.h"

#include "platform/weborigin/SecurityOrigin.h"

@@ -313,7 +312,8 @@

if (!SubframeLoadingDisabler::canLoadFrame(*this))

return false;

- if (document().frame()->host()->subframeCount() >= Page::maxNumberOfFrames)

+ if (document().frame()->host()->subframeCount() >=

+ FrameHost::maxNumberOfFrames)

return false;

FrameLoadRequest frameLoadRequest(&document(), url, "_self",