MD About: controlled indicator for change channel option

MD About: controlled indicator for change channel option

In the MD About details page, if the channel cannot be changed, show the correct
source (currently we always show enterprise, even for non-enrolled devices).
This also gives the indicator a tooltip, bringing it in line with our other
indicators.

BUG=317936
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2746643002
Cr-Commit-Position: refs/heads/master@{#456576}
Committed: https://chromium.googlesource.com/chromium/src/+/ca6d6c06d92029d088467442413b8fcc4ec22783

[michaelpg, 2017-03-10 23:22:44]

Description was changed from

==========
MD About: controlled indicator for change channel option

In the MD About details page, if the channel cannot be changed, show the correct
source (currently we always show enterprise, even for non-enrolled devices).
This also gives the indicator a tooltip, bringing it in line with our other
indicators.

BUG=317936
R=stevenjb@chromium.org
==========

to

==========
MD About: controlled indicator for change channel option

In the MD About details page, if the channel cannot be changed, show the correct
source (currently we always show enterprise, even for non-enrolled devices).
This also gives the indicator a tooltip, bringing it in line with our other
indicators.

BUG=317936
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2017-03-10 23:27:07]

PTAL, fixes a longstanding issue we copied into MD Help from Options

[stevenjb, 2017-03-11 00:17:00]

lgtm w/ a suggesiton

https://codereview.chromium.org/2746643002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/2746643002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1816:
#endif
nit: maybe move this to AddMultiProfilesStrings (and maybe rename that).

[michaelpg, 2017-03-13 23:34:43]

https://codereview.chromium.org/2746643002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/2746643002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1816:
#endif
On 2017/03/11 00:17:00, stevenjb wrote:
> nit: maybe move this to AddMultiProfilesStrings (and maybe rename that).

Done (AddChromeOSUserStrings)

[michaelpg, 2017-03-13 23:34:46]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2017-03-13 23:34:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2746643002/#ps40001
(title: "format")

[michaelpg, 2017-03-13 23:34:49]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2017-03-13 23:35:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 02:15:52]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489448089252150,
"parent_rev": "eeb280562292e14bdfc3dfa494f6599a1d43ae2b", "commit_rev":
"ca6d6c06d92029d088467442413b8fcc4ec22783"}

[commit-bot: I haz the power, 2017-03-14 02:16:36]

Description was changed from

==========
MD About: controlled indicator for change channel option

In the MD About details page, if the channel cannot be changed, show the correct
source (currently we always show enterprise, even for non-enrolled devices).
This also gives the indicator a tooltip, bringing it in line with our other
indicators.

BUG=317936
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD About: controlled indicator for change channel option

In the MD About details page, if the channel cannot be changed, show the correct
source (currently we always show enterprise, even for non-enrolled devices).
This also gives the indicator a tooltip, bringing it in line with our other
indicators.

BUG=317936
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2746643002
Cr-Commit-Position: refs/heads/master@{#456576}
Committed:
https://chromium.googlesource.com/chromium/src/+/ca6d6c06d92029d088467442413b...
==========

[commit-bot: I haz the power, 2017-03-14 02:16:37]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ca6d6c06d92029d088467442413b...

[Dan Beam, 2017-03-14 18:11:53]

https://codereview.chromium.org/2746643002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/2746643002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1967:
AddChromeOSUserStrings(html_source, profile);
this was alphabetized

[michaelpg, 2017-03-14 23:09:04]

https://codereview.chromium.org/2746643002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/2746643002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1967:
AddChromeOSUserStrings(html_source, profile);
On 2017/03/14 18:11:53, Dan Beam wrote:
> this was alphabetized

ah, didn't realize that.

I saw that the function definitions themselves had gotten out of order so I
figured moving AddChromeOSUserStrings's definition wasn't worth the code churn,
but since these *calls* were properly ordered I'll fix this line:
https://codereview.chromium.org/2745053008