Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2745053008: Alphabetize settings::AddLocalizedStrings (Closed)

Created:
3 years, 9 months ago by michaelpg
Modified:
3 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Alphabetize settings::AddLocalizedStrings Follow-up to fix alphabetization from crrev.com/2746643002 Only fixes the function invocation, as the function definitions were already not perfectly alphabetized and it doesn't seem worth the blame churn to reorder them. BUG=none R=dbeam@chromium.org Review-Url: https://codereview.chromium.org/2745053008 Cr-Commit-Position: refs/heads/master@{#456909} Committed: https://chromium.googlesource.com/chromium/src/+/f085ffc2134c827c5fa3a91b64b94a02e56323df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
michaelpg
3 years, 9 months ago (2017-03-14 23:09:35 UTC) #2
Dan Beam
lgtm whewww!
3 years, 9 months ago (2017-03-14 23:12:11 UTC) #3
michaelpg
On 2017/03/14 23:12:11, Dan Beam wrote: > lgtm whewww! Yeah you know it's scary when ...
3 years, 9 months ago (2017-03-14 23:18:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745053008/1
3 years, 9 months ago (2017-03-14 23:19:46 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 00:19:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f085ffc2134c827c5fa3a91b64b9...

Powered by Google App Engine
This is Rietveld 408576698