Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4327)

Unified Diff: chrome/browser/ui/webui/settings/about_handler.cc

Issue 2746643002: MD About: controlled indicator for change channel option (Closed)
Patch Set: format Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/about_handler.cc
diff --git a/chrome/browser/ui/webui/settings/about_handler.cc b/chrome/browser/ui/webui/settings/about_handler.cc
index dd1d2197a8ca0d53d038a67f56d71e37c8d0afb3..78fd9d97d62e190ae6083663e6d2b71901e784e2 100644
--- a/chrome/browser/ui/webui/settings/about_handler.cc
+++ b/chrome/browser/ui/webui/settings/about_handler.cc
@@ -113,16 +113,16 @@ bool IsEnterpriseManaged() {
// Returns true if current user can change channel, false otherwise.
bool CanChangeChannel(Profile* profile) {
- bool value = false;
- chromeos::CrosSettings::Get()->GetBoolean(chromeos::kReleaseChannelDelegated,
- &value);
-
// On a managed machine we delegate this setting to the users of the same
// domain only if the policy value is "domain".
if (IsEnterpriseManaged()) {
+ bool value = false;
+ chromeos::CrosSettings::Get()->GetBoolean(
+ chromeos::kReleaseChannelDelegated, &value);
if (!value)
return false;
- // Get the currently logged in user and strip the domain part only.
+
+ // Get the currently logged-in user and strip the domain part only.
std::string domain = "";
const user_manager::User* user =
profile ? chromeos::ProfileHelper::Get()->GetUserByProfile(profile)
@@ -135,16 +135,13 @@ bool CanChangeChannel(Profile* profile) {
policy::BrowserPolicyConnectorChromeOS* connector =
g_browser_process->platform_part()->browser_policy_connector_chromeos();
return domain == connector->GetEnterpriseDomain();
- } else {
- chromeos::OwnerSettingsServiceChromeOS* service =
- chromeos::OwnerSettingsServiceChromeOSFactory::GetInstance()
- ->GetForBrowserContext(profile);
- // On non managed machines we have local owner who is the only one to change
- // anything. Ensure that ReleaseChannelDelegated is false.
- if (service && service->IsOwner())
- return !value;
}
- return false;
+
+ // On non-managed machines, only the local owner can change the channel.
+ chromeos::OwnerSettingsServiceChromeOS* service =
+ chromeos::OwnerSettingsServiceChromeOSFactory::GetInstance()
+ ->GetForBrowserContext(profile);
+ return service && service->IsOwner();
}
// Returns the path of the regulatory labels directory for a given region, if

Powered by Google App Engine
This is Rietveld 408576698