Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2746493002:
Reland of Statically link libprotobuf_lite on Linux (Closed)
|
Created:
3 years, 9 months ago by Tom (Use chromium acct) Modified:
3 years, 9 months ago CC:
chromium-reviews, Dirk Pranke, Raghu Simha Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReland of Statically link libprotobuf_lite on Linux
Chrome has a direct dependency on a custom libprotobuf_lite in
third_party, but Xenial and Yakkety add a dependency on the system
libprotobuf-lite via Mir (which gets loaded from Gtk).
Our third_party protobuf is not compatible with the upstream protobuf.
Combine this with the fact that Xenial uses version 2 while Yakkety
uses version 3, and it's basically impossible to make our third_party
protobuf cooperate with the system one. The solution is to always
statically link protobuf on Linux.
BUG=79722, 700120
R=pkasting@chromium.org
TBR=bengr@chromium.org
CC=dpranke@chromium.org,rsimha@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.win:win_chromium_dbg_ng;master.tryserver.chromium.mac:mac_chromium_dbg_ng
> Review-Url: https://codereview.chromium.org/2746493002
> Cr-Commit-Position: refs/heads/master@{#455936}
> Committed: https://chromium.googlesource.com/chromium/src/+/4af1264005620a483a209f4344c3782f62eee69a
Patch Set 1 #Patch Set 2 : Add dependency on protobuf_lite from net_unittests #Patch Set 3 : [PROOF OF CONCEPT FIX, DO NOT LAND] #Patch Set 4 : [FIX ODR ERROR, WIP, DO NOT LAND] #Patch Set 5 : Refactor #Patch Set 6 : Fix Win dbg #Patch Set 7 : Really fix Win dbg #
Messages
Total messages: 76 (65 generated)
pkasting@ ptal
LGTM
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Statically link libprotobuf_lite on Linux Chrome has a direct dependency on a custom libprotobuf_lite in third_party, but Xenial and Yakkety add a dependency on the system libprotobuf-lite via Mir (which gets loaded from Gtk). Our third_party protobuf is not compatible with the upstream protobuf. Combine this with the fact that Xenial uses version 2 while Yakkety uses version 3, and it's basically impossible to make our third_party protobuf cooperate with the system one. The solution is to always statically link protobuf on Linux. BUG=79722,700120 R=pkasting@chromium.org CC=dpranke@chromium.org,rsimha@chromium.org ========== to ========== Statically link libprotobuf_lite on Linux Chrome has a direct dependency on a custom libprotobuf_lite in third_party, but Xenial and Yakkety add a dependency on the system libprotobuf-lite via Mir (which gets loaded from Gtk). Our third_party protobuf is not compatible with the upstream protobuf. Combine this with the fact that Xenial uses version 2 while Yakkety uses version 3, and it's basically impossible to make our third_party protobuf cooperate with the system one. The solution is to always statically link protobuf on Linux. BUG=79722,700120 R=pkasting@chromium.org TBR=bengr@chromium.org CC=dpranke@chromium.org,rsimha@chromium.org ==========
TBR'ing bengr@ for a trivial change in //net net_unittests had a dependency on libprotobuf_lite (eg. in net/quic/core/crypto/quic_crypto_server_config_test.cc:249), however this dependency was not listed in deps. The latest PS adds this
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thomasanderson@google.com changed reviewers: + bengr@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thomasanderson@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from pkasting@chromium.org Link to the patchset: https://codereview.chromium.org/2746493002/#ps20001 (title: "Add dependency on protobuf_lite from net_unittests")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489107364260490,
"parent_rev": "7ae9f6fc18857892d7ffc3d5d3203720dd198c9f", "commit_rev":
"4af1264005620a483a209f4344c3782f62eee69a"}
Message was sent while issue was closed.
Description was changed from ========== Statically link libprotobuf_lite on Linux Chrome has a direct dependency on a custom libprotobuf_lite in third_party, but Xenial and Yakkety add a dependency on the system libprotobuf-lite via Mir (which gets loaded from Gtk). Our third_party protobuf is not compatible with the upstream protobuf. Combine this with the fact that Xenial uses version 2 while Yakkety uses version 3, and it's basically impossible to make our third_party protobuf cooperate with the system one. The solution is to always statically link protobuf on Linux. BUG=79722,700120 R=pkasting@chromium.org TBR=bengr@chromium.org CC=dpranke@chromium.org,rsimha@chromium.org ========== to ========== Statically link libprotobuf_lite on Linux Chrome has a direct dependency on a custom libprotobuf_lite in third_party, but Xenial and Yakkety add a dependency on the system libprotobuf-lite via Mir (which gets loaded from Gtk). Our third_party protobuf is not compatible with the upstream protobuf. Combine this with the fact that Xenial uses version 2 while Yakkety uses version 3, and it's basically impossible to make our third_party protobuf cooperate with the system one. The solution is to always statically link protobuf on Linux. BUG=79722,700120 R=pkasting@chromium.org TBR=bengr@chromium.org CC=dpranke@chromium.org,rsimha@chromium.org Review-Url: https://codereview.chromium.org/2746493002 Cr-Commit-Position: refs/heads/master@{#455936} Committed: https://chromium.googlesource.com/chromium/src/+/4af1264005620a483a209f4344c3... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4af1264005620a483a209f4344c3...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2739203004/ by kinuko@chromium.org. The reason for reverting is: Not sure why, but it looks this starts to cause CloudPolicyManagerTest failures. (Confirmed that locally reverting this CL fixed them) https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2... https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2... CloudPolicyManagerTest.Register CloudPolicyManagerTest.RegisterWithRetry failed to process gtest output JSON CloudPolicyProtoTest.VerifyProtobufEquivalence .
Message was sent while issue was closed.
Description was changed from ========== Statically link libprotobuf_lite on Linux Chrome has a direct dependency on a custom libprotobuf_lite in third_party, but Xenial and Yakkety add a dependency on the system libprotobuf-lite via Mir (which gets loaded from Gtk). Our third_party protobuf is not compatible with the upstream protobuf. Combine this with the fact that Xenial uses version 2 while Yakkety uses version 3, and it's basically impossible to make our third_party protobuf cooperate with the system one. The solution is to always statically link protobuf on Linux. BUG=79722,700120 R=pkasting@chromium.org TBR=bengr@chromium.org CC=dpranke@chromium.org,rsimha@chromium.org Review-Url: https://codereview.chromium.org/2746493002 Cr-Commit-Position: refs/heads/master@{#455936} Committed: https://chromium.googlesource.com/chromium/src/+/4af1264005620a483a209f4344c3... ========== to ========== Statically link libprotobuf_lite on Linux Chrome has a direct dependency on a custom libprotobuf_lite in third_party, but Xenial and Yakkety add a dependency on the system libprotobuf-lite via Mir (which gets loaded from Gtk). Our third_party protobuf is not compatible with the upstream protobuf. Combine this with the fact that Xenial uses version 2 while Yakkety uses version 3, and it's basically impossible to make our third_party protobuf cooperate with the system one. The solution is to always statically link protobuf on Linux. BUG=79722,700120 R=pkasting@chromium.org TBR=bengr@chromium.org CC=dpranke@chromium.org,rsimha@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng > Review-Url: https://codereview.chromium.org/2746493002 > Cr-Commit-Position: refs/heads/master@{#455936} > Committed: https://chromium.googlesource.com/chromium/src/+/4af1264005620a483a209f4344c3... ==========
Description was changed from ========== Statically link libprotobuf_lite on Linux Chrome has a direct dependency on a custom libprotobuf_lite in third_party, but Xenial and Yakkety add a dependency on the system libprotobuf-lite via Mir (which gets loaded from Gtk). Our third_party protobuf is not compatible with the upstream protobuf. Combine this with the fact that Xenial uses version 2 while Yakkety uses version 3, and it's basically impossible to make our third_party protobuf cooperate with the system one. The solution is to always statically link protobuf on Linux. BUG=79722,700120 R=pkasting@chromium.org TBR=bengr@chromium.org CC=dpranke@chromium.org,rsimha@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng > Review-Url: https://codereview.chromium.org/2746493002 > Cr-Commit-Position: refs/heads/master@{#455936} > Committed: https://chromium.googlesource.com/chromium/src/+/4af1264005620a483a209f4344c3... ========== to ========== Reland of Statically link libprotobuf_lite on Linux Chrome has a direct dependency on a custom libprotobuf_lite in third_party, but Xenial and Yakkety add a dependency on the system libprotobuf-lite via Mir (which gets loaded from Gtk). Our third_party protobuf is not compatible with the upstream protobuf. Combine this with the fact that Xenial uses version 2 while Yakkety uses version 3, and it's basically impossible to make our third_party protobuf cooperate with the system one. The solution is to always statically link protobuf on Linux. BUG=79722,700120 R=pkasting@chromium.org TBR=bengr@chromium.org CC=dpranke@chromium.org,rsimha@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng > Review-Url: https://codereview.chromium.org/2746493002 > Cr-Commit-Position: refs/heads/master@{#455936} > Committed: https://chromium.googlesource.com/chromium/src/+/4af1264005620a483a209f4344c3... ==========
Description was changed from ========== Reland of Statically link libprotobuf_lite on Linux Chrome has a direct dependency on a custom libprotobuf_lite in third_party, but Xenial and Yakkety add a dependency on the system libprotobuf-lite via Mir (which gets loaded from Gtk). Our third_party protobuf is not compatible with the upstream protobuf. Combine this with the fact that Xenial uses version 2 while Yakkety uses version 3, and it's basically impossible to make our third_party protobuf cooperate with the system one. The solution is to always statically link protobuf on Linux. BUG=79722,700120 R=pkasting@chromium.org TBR=bengr@chromium.org CC=dpranke@chromium.org,rsimha@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng > Review-Url: https://codereview.chromium.org/2746493002 > Cr-Commit-Position: refs/heads/master@{#455936} > Committed: https://chromium.googlesource.com/chromium/src/+/4af1264005620a483a209f4344c3... ========== to ========== Statically link libprotobuf_lite on Linux Chrome has a direct dependency on a custom libprotobuf_lite in third_party, but Xenial and Yakkety add a dependency on the system libprotobuf-lite via Mir (which gets loaded from Gtk). Our third_party protobuf is not compatible with the upstream protobuf. Combine this with the fact that Xenial uses version 2 while Yakkety uses version 3, and it's basically impossible to make our third_party protobuf cooperate with the system one. The solution is to always statically link protobuf on Linux. BUG=79722,700120 R=pkasting@chromium.org TBR=bengr@chromium.org CC=dpranke@chromium.org,rsimha@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng > Review-Url: https://codereview.chromium.org/2746493002 > Cr-Commit-Position: refs/heads/master@{#455936} > Committed: https://chromium.googlesource.com/chromium/src/+/4af1264005620a483a209f4344c3... ==========
Message was sent while issue was closed.
Description was changed from ========== Statically link libprotobuf_lite on Linux Chrome has a direct dependency on a custom libprotobuf_lite in third_party, but Xenial and Yakkety add a dependency on the system libprotobuf-lite via Mir (which gets loaded from Gtk). Our third_party protobuf is not compatible with the upstream protobuf. Combine this with the fact that Xenial uses version 2 while Yakkety uses version 3, and it's basically impossible to make our third_party protobuf cooperate with the system one. The solution is to always statically link protobuf on Linux. BUG=79722,700120 R=pkasting@chromium.org TBR=bengr@chromium.org CC=dpranke@chromium.org,rsimha@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng > Review-Url: https://codereview.chromium.org/2746493002 > Cr-Commit-Position: refs/heads/master@{#455936} > Committed: https://chromium.googlesource.com/chromium/src/+/4af1264005620a483a209f4344c3... ========== to ========== Reland of Statically link libprotobuf_lite on Linux Chrome has a direct dependency on a custom libprotobuf_lite in third_party, but Xenial and Yakkety add a dependency on the system libprotobuf-lite via Mir (which gets loaded from Gtk). Our third_party protobuf is not compatible with the upstream protobuf. Combine this with the fact that Xenial uses version 2 while Yakkety uses version 3, and it's basically impossible to make our third_party protobuf cooperate with the system one. The solution is to always statically link protobuf on Linux. BUG=79722,700120 R=pkasting@chromium.org TBR=bengr@chromium.org CC=dpranke@chromium.org,rsimha@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng > Review-Url: https://codereview.chromium.org/2746493002 > Cr-Commit-Position: refs/heads/master@{#455936} > Committed: https://chromium.googlesource.com/chromium/src/+/4af1264005620a483a209f4344c3... ==========
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Reland of Statically link libprotobuf_lite on Linux Chrome has a direct dependency on a custom libprotobuf_lite in third_party, but Xenial and Yakkety add a dependency on the system libprotobuf-lite via Mir (which gets loaded from Gtk). Our third_party protobuf is not compatible with the upstream protobuf. Combine this with the fact that Xenial uses version 2 while Yakkety uses version 3, and it's basically impossible to make our third_party protobuf cooperate with the system one. The solution is to always statically link protobuf on Linux. BUG=79722,700120 R=pkasting@chromium.org TBR=bengr@chromium.org CC=dpranke@chromium.org,rsimha@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng > Review-Url: https://codereview.chromium.org/2746493002 > Cr-Commit-Position: refs/heads/master@{#455936} > Committed: https://chromium.googlesource.com/chromium/src/+/4af1264005620a483a209f4344c3... ========== to ========== Reland of Statically link libprotobuf_lite on Linux Chrome has a direct dependency on a custom libprotobuf_lite in third_party, but Xenial and Yakkety add a dependency on the system libprotobuf-lite via Mir (which gets loaded from Gtk). Our third_party protobuf is not compatible with the upstream protobuf. Combine this with the fact that Xenial uses version 2 while Yakkety uses version 3, and it's basically impossible to make our third_party protobuf cooperate with the system one. The solution is to always statically link protobuf on Linux. BUG=79722,700120 R=pkasting@chromium.org TBR=bengr@chromium.org CC=dpranke@chromium.org,rsimha@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.win:win_chromium_dbg_ng > Review-Url: https://codereview.chromium.org/2746493002 > Cr-Commit-Position: refs/heads/master@{#455936} > Committed: https://chromium.googlesource.com/chromium/src/+/4af1264005620a483a209f4344c3... ==========
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Patchset #4 (id:60001) has been deleted
Description was changed from ========== Reland of Statically link libprotobuf_lite on Linux Chrome has a direct dependency on a custom libprotobuf_lite in third_party, but Xenial and Yakkety add a dependency on the system libprotobuf-lite via Mir (which gets loaded from Gtk). Our third_party protobuf is not compatible with the upstream protobuf. Combine this with the fact that Xenial uses version 2 while Yakkety uses version 3, and it's basically impossible to make our third_party protobuf cooperate with the system one. The solution is to always statically link protobuf on Linux. BUG=79722,700120 R=pkasting@chromium.org TBR=bengr@chromium.org CC=dpranke@chromium.org,rsimha@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.win:win_chromium_dbg_ng > Review-Url: https://codereview.chromium.org/2746493002 > Cr-Commit-Position: refs/heads/master@{#455936} > Committed: https://chromium.googlesource.com/chromium/src/+/4af1264005620a483a209f4344c3... ========== to ========== Reland of Statically link libprotobuf_lite on Linux Chrome has a direct dependency on a custom libprotobuf_lite in third_party, but Xenial and Yakkety add a dependency on the system libprotobuf-lite via Mir (which gets loaded from Gtk). Our third_party protobuf is not compatible with the upstream protobuf. Combine this with the fact that Xenial uses version 2 while Yakkety uses version 3, and it's basically impossible to make our third_party protobuf cooperate with the system one. The solution is to always statically link protobuf on Linux. BUG=79722,700120 R=pkasting@chromium.org TBR=bengr@chromium.org CC=dpranke@chromium.org,rsimha@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.win:win_chromium_dbg_ng;master.tryserver.chromium.mac:mac_chromium_dbg_ng > Review-Url: https://codereview.chromium.org/2746493002 > Cr-Commit-Position: refs/heads/master@{#455936} > Committed: https://chromium.googlesource.com/chromium/src/+/4af1264005620a483a209f4344c3... ==========
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #5 (id:100001) has been deleted
pkasting@ please take another look Maybe we should just revert the gtk3 switch in the meantime? There are devs at intel and igalia that are pseudo-blocked on this.
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) win_chromium_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_dbg_...)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by thomasanderson@google.com
Patchset #6 (id:140001) has been deleted
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
Patchset #5 (id:120001) has been deleted
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by thomasanderson@google.com
Patchset #6 (id:180001) has been deleted
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_dbg_...)
Patchset #6 (id:200001) has been deleted
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_dbg_...)
Patchset #6 (id:220001) has been deleted
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
On 2017/03/15 01:41:59, Tom Anderson wrote: > pkasting@ please take another look This definitely seems saner, and is maybe something upstream would be willing to accept. I dunno.
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_dbg_...) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
