Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: third_party/protobuf/README.chromium

Issue 2746493002: Reland of Statically link libprotobuf_lite on Linux (Closed)
Patch Set: Really fix Win dbg Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/protobuf/BUILD.gn ('k') | third_party/protobuf/patches/0012-extract-globals.patch » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/protobuf/README.chromium
diff --git a/third_party/protobuf/README.chromium b/third_party/protobuf/README.chromium
index 8838fbc2715f88ba266247fb32e58147b04ad0a0..12d36bf7f1cec839a9d93702518f33b6244542e7 100644
--- a/third_party/protobuf/README.chromium
+++ b/third_party/protobuf/README.chromium
@@ -76,3 +76,10 @@ Description of the patches:
removed in C++11 mode.
Fixed in https://github.com/google/protobuf/pull/1549
+
+- 0012-extract-globals.patch
+
+ Fixes https://crbug.com/700120. Moves empty_string_ into globals.cc so that
+ Chromium may build a shared library containing just protobuf globals. Also
+ renames it to cr_empty_string_ to not conflict with the system protobuf on
+ Linux.
« no previous file with comments | « third_party/protobuf/BUILD.gn ('k') | third_party/protobuf/patches/0012-extract-globals.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698