Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2739203004: Revert of Statically link libprotobuf_lite on Linux (Closed)

Created:
3 years, 9 months ago by kinuko
Modified:
3 years, 9 months ago
CC:
chromium-reviews, Dirk Pranke, Raghu Simha
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Statically link libprotobuf_lite on Linux (patchset #2 id:20001 of https://codereview.chromium.org/2746493002/ ) Reason for revert: Not sure why, but it looks this starts to cause CloudPolicyManagerTest failures. (Confirmed that locally reverting this CL fixed them) https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/39213 https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/39214 CloudPolicyManagerTest.Register CloudPolicyManagerTest.RegisterWithRetry failed to process gtest output JSON CloudPolicyProtoTest.VerifyProtobufEquivalence Original issue's description: > Statically link libprotobuf_lite on Linux > > Chrome has a direct dependency on a custom libprotobuf_lite in > third_party, but Xenial and Yakkety add a dependency on the system > libprotobuf-lite via Mir (which gets loaded from Gtk). > > Our third_party protobuf is not compatible with the upstream protobuf. > Combine this with the fact that Xenial uses version 2 while Yakkety > uses version 3, and it's basically impossible to make our third_party > protobuf cooperate with the system one. The solution is to always > statically link protobuf on Linux. > > BUG=79722, 700120 > R=pkasting@chromium.org > TBR=bengr@chromium.org > CC=dpranke@chromium.org,rsimha@chromium.org > > Review-Url: https://codereview.chromium.org/2746493002 > Cr-Commit-Position: refs/heads/master@{#455936} > Committed: https://chromium.googlesource.com/chromium/src/+/4af1264005620a483a209f4344c3782f62eee69a TBR=pkasting@chromium.org,bengr@chromium.org,thomasanderson@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=79722, 700120 Review-Url: https://codereview.chromium.org/2739203004 Cr-Commit-Position: refs/heads/master@{#456013} Committed: https://chromium.googlesource.com/chromium/src/+/9e80d868029c25fdb129f85d0f8f75e8f6c013e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M net/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/protobuf/BUILD.gn View 2 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kinuko
Created Revert of Statically link libprotobuf_lite on Linux
3 years, 9 months ago (2017-03-10 07:14:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739203004/1
3 years, 9 months ago (2017-03-10 07:14:54 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 07:16:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9e80d868029c25fdb129f85d0f8f...

Powered by Google App Engine
This is Rietveld 408576698