Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2742713007: [ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:unit_tests to ARC. (Closed)

Created:
3 years, 9 months ago by stkhapugin
Modified:
3 years, 9 months ago
Reviewers:
lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, tfarina, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2742713007 Cr-Commit-Position: refs/heads/master@{#459405} Committed: https://chromium.googlesource.com/chromium/src/+/9ed6f857a700f5a9cda4513050e1f908628ade10

Patch Set 1 #

Patch Set 2 : update dependency list and rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M ios/chrome/browser/ui/bookmarks/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller_unittest.mm View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_ios_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_position_cache_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (9 generated)
stkhapugin
PTAL. CQ might fail the first time because this currently depends on a wrong patch ...
3 years, 9 months ago (2017-03-10 15:26:32 UTC) #4
lpromero
lgtm
3 years, 9 months ago (2017-03-10 15:48:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742713007/40001
3 years, 9 months ago (2017-03-24 12:26:41 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 13:30:06 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9ed6f857a700f5a9cda4513050e1...

Powered by Google App Engine
This is Rietveld 408576698