[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks to ARC.

ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.h"
 
 #import <QuartzCore/QuartzCore.h>
 
 #include "base/logging.h"
-#import "base/mac/objc_property_releaser.h"
-#import "base/mac/scoped_nsobject.h"
+
 #import "ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.h"
 #import "ios/chrome/browser/ui/colors/MDCPalette+CrAdditions.h"
 #import "ios/chrome/browser/ui/rtl_geometry.h"
 #import "ios/chrome/browser/ui/uikit_ui_util.h"
 #include "ios/chrome/grit/ios_chromium_strings.h"
 #include "ios/chrome/grit/ios_strings.h"
 #import "ios/third_party/material_components_ios/src/components/Buttons/src/MaterialButtons.h"
 #import "ios/third_party/material_roboto_font_loader_ios/src/src/MaterialRobotoFontLoader.h"
 #import "ui/base/l10n/l10n_util_mac.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 namespace {
 
 const CGFloat kPadding = 16;
 const CGFloat kButtonHeight = 36;
 const CGFloat kTitleSubtitleSpace = 8;
 const CGFloat kSubtitleButtonsSpace = 8;
 const CGFloat kButtonsSpace = 8;
 
 void SetTextWithLineHeight(UILabel* label, NSString* text, CGFloat lineHeight) {
-  base::scoped_nsobject<NSMutableParagraphStyle> paragraphStyle(
-      [[NSMutableParagraphStyle alloc] init]);
+  NSMutableParagraphStyle* paragraphStyle =
+      [[NSMutableParagraphStyle alloc] init];
   [paragraphStyle setMinimumLineHeight:lineHeight];
   [paragraphStyle setMaximumLineHeight:lineHeight];
   NSDictionary* attributes = @{NSParagraphStyleAttributeName : paragraphStyle};
-  base::scoped_nsobject<NSAttributedString> attributedString(
-      [[NSAttributedString alloc] initWithString:text attributes:attributes]);
+  NSAttributedString* attributedString =
+      [[NSAttributedString alloc] initWithString:text attributes:attributes];
   label.attributedText = attributedString;
 }
 
 }  // namespace
 
 // The view that contains the promo UI: the title, the subtitle, the dismiss and
 // the sign in buttons. It is common to all size classes, but can be embedded
 // differently within the BookmarkPromoCell.
 @interface BookmarkPromoView : UIView
 
-@property(nonatomic, assign) UILabel* titleLabel;
-@property(nonatomic, assign) UILabel* subtitleLabel;
-@property(nonatomic, assign) MDCFlatButton* signInButton;
-@property(nonatomic, assign) MDCFlatButton* dismissButton;
+@property(nonatomic, weak) UILabel* titleLabel;
+@property(nonatomic, weak) UILabel* subtitleLabel;
+@property(nonatomic, weak) MDCFlatButton* signInButton;
+@property(nonatomic, weak) MDCFlatButton* dismissButton;
 
 @end
 
 @implementation BookmarkPromoView
 
 @synthesize titleLabel = _titleLabel;
 @synthesize subtitleLabel = _subtitleLabel;
 @synthesize signInButton = _signInButton;
 @synthesize dismissButton = _dismissButton;
 
 + (BOOL)requiresConstraintBasedLayout {
   return YES;
 }
 
 - (instancetype)initWithFrame:(CGRect)frame {
   self = [super initWithFrame:frame];
   if (self) {
     self.backgroundColor = [UIColor whiteColor];
     self.accessibilityIdentifier = @"promo_view";
 
     // The title.
-    _titleLabel = [[[UILabel alloc] init] autorelease];
+    UILabel* titleLabel = [[UILabel alloc] init];
+    _titleLabel = titleLabel;
     _titleLabel.textColor = bookmark_utils_ios::darkTextColor();
     _titleLabel.font =
         [[MDFRobotoFontLoader sharedInstance] mediumFontOfSize:16];
     _titleLabel.numberOfLines = 0;
     SetTextWithLineHeight(_titleLabel,
                           l10n_util::GetNSString(IDS_IOS_BOOKMARK_PROMO_TITLE),
                           20.f);
     _titleLabel.translatesAutoresizingMaskIntoConstraints = NO;
     [self addSubview:_titleLabel];
 
     // The subtitle.
-    _subtitleLabel = [[[UILabel alloc] init] autorelease];
+    UILabel* subtitleLabel = [[UILabel alloc] init];
+    _subtitleLabel = subtitleLabel;
     _subtitleLabel.textColor = bookmark_utils_ios::darkTextColor();
     _subtitleLabel.font =
         [[MDFRobotoFontLoader sharedInstance] regularFontOfSize:14];
     _subtitleLabel.numberOfLines = 0;
     SetTextWithLineHeight(
         _subtitleLabel, l10n_util::GetNSString(IDS_IOS_BOOKMARK_PROMO_MESSAGE),
         20.f);
     _subtitleLabel.translatesAutoresizingMaskIntoConstraints = NO;
     [self addSubview:_subtitleLabel];
 
     // The sign-in button.
-    _signInButton = [[[MDCFlatButton alloc] init] autorelease];
+    MDCFlatButton* signInButton = [[MDCFlatButton alloc] init];
+    _signInButton = signInButton;
     [_signInButton setBackgroundColor:[[MDCPalette cr_bluePalette] tint500]
                              forState:UIControlStateNormal];
     _signInButton.customTitleColor = [UIColor whiteColor];
     _signInButton.inkColor = [UIColor colorWithWhite:1 alpha:0.2];
     [_signInButton
         setTitle:l10n_util::GetNSString(IDS_IOS_BOOKMARK_PROMO_SIGN_IN_BUTTON)
         forState:UIControlStateNormal];
     _signInButton.accessibilityIdentifier = @"promo_sign_in_button";
     _signInButton.translatesAutoresizingMaskIntoConstraints = NO;
     [self addSubview:_signInButton];
 
     // The dismiss button.
-    _dismissButton = [[[MDCFlatButton alloc] init] autorelease];
+    MDCFlatButton* dismissButton = [[MDCFlatButton alloc] init];
+    _dismissButton = dismissButton;
     [_dismissButton
         setTitle:l10n_util::GetNSString(IDS_IOS_BOOKMARK_PROMO_DISMISS_BUTTON)
         forState:UIControlStateNormal];
     _dismissButton.customTitleColor = [[MDCPalette cr_bluePalette] tint500];
     _dismissButton.accessibilityIdentifier = @"promo_no_thanks_button";
     _dismissButton.translatesAutoresizingMaskIntoConstraints = NO;
     [self addSubview:_dismissButton];
   }
   return self;
 }
@@ skipping 24 matching lines @@
     ApplyVisualConstraintsWithMetricsAndOptions(
         constraints, views, metrics, LayoutOptionForRTLSupport(), self);
     AddSameCenterYConstraint(self, self.signInButton, self.dismissButton);
   }
   [super updateConstraints];
 }
 
 @end
 
 @interface BookmarkPromoCell () {
-  base::mac::ObjCPropertyReleaser _propertyReleaser_BookmarkPromoCell;
 }
-@property(nonatomic, assign) BookmarkPromoView* promoView;
-@property(nonatomic, retain) NSArray* compactContentViewConstraints;
-@property(nonatomic, retain) NSArray* regularContentViewConstraints;
+@property(nonatomic, weak) BookmarkPromoView* promoView;
+@property(nonatomic, strong) NSArray* compactContentViewConstraints;
+@property(nonatomic, strong) NSArray* regularContentViewConstraints;
 @end
 
 @implementation BookmarkPromoCell
 
 @synthesize delegate = _delegate;
 @synthesize promoView = _promoView;
 @synthesize compactContentViewConstraints = _compactContentViewConstraints;
 @synthesize regularContentViewConstraints = _regularContentViewConstraints;
 
 + (NSString*)reuseIdentifier {
   return @"BookmarkPromoCell";
 }
 
 + (BOOL)requiresConstraintBasedLayout {
   return YES;
 }
 
 - (instancetype)initWithFrame:(CGRect)frame {
   self = [super initWithFrame:frame];
   if (self) {
-    _propertyReleaser_BookmarkPromoCell.Init(self, [BookmarkPromoCell class]);
     self.contentView.translatesAutoresizingMaskIntoConstraints = NO;
 
-    _promoView = [[[BookmarkPromoView alloc] initWithFrame:frame] autorelease];
+    BookmarkPromoView* promoView =
+        [[BookmarkPromoView alloc] initWithFrame:frame];
+    _promoView = promoView;

[lpromero, 2017/03/10 16:06:18]

One-liner instead?

[stkhapugin, 2017/03/10 16:17:19]

Not sure if you are proposing to put 

BookmarkPromoView* promoView =
        [[BookmarkPromoView alloc] initWithFrame:frame];

on one line (this doesn't fit), or use _promoView = ...; and not introduce the
intermediary reference (this doesn't work because the ivar is weak and the
object will be immediately deallocated)

[lpromero, 2017/03/10 16:19:59]

That was the second. Thanks for the explanation!

     [_promoView.signInButton addTarget:self
                                 action:@selector(signIn:)
                       forControlEvents:UIControlEventTouchUpInside];
     [_promoView.dismissButton addTarget:self
                                  action:@selector(dismiss:)
                        forControlEvents:UIControlEventTouchUpInside];
     _promoView.translatesAutoresizingMaskIntoConstraints = NO;
     [self.contentView addSubview:_promoView];
     [self updatePromoView];
   }
@@ skipping 87 matching lines @@
 
 - (void)signIn:(id)sender {
   [self.delegate bookmarkPromoCellDidTapSignIn:self];
 }
 
 - (void)dismiss:(id)sender {
   [self.delegate bookmarkPromoCellDidTapDismiss:self];
 }
 
 @end