Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2746423002: Safe media metadata parser: create mojo client with MakeUnique<> (Closed)

Created:
3 years, 9 months ago by Noel Gordon
Modified:
3 years, 9 months ago
CC:
chromium-reviews, Lei Zhang, tommycli, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Safe media metadata parser: create mojo client with MakeUnique<> Create the utility process mojo client with base::MakeUnique<>. No change in behavior, no new tests. BUG=680928 Review-Url: https://codereview.chromium.org/2746423002 Cr-Commit-Position: refs/heads/master@{#456917} Committed: https://chromium.googlesource.com/chromium/src/+/4434f5f0845ff380c65da956e31ff5ecf1f6b5a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc View 1 chunk +4 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (11 generated)
Noel Gordon
3 years, 9 months ago (2017-03-14 13:16:16 UTC) #8
Sam McNally
lgtm
3 years, 9 months ago (2017-03-14 23:22:49 UTC) #10
tommycli
lgtm
3 years, 9 months ago (2017-03-14 23:33:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746423002/1
3 years, 9 months ago (2017-03-15 00:23:21 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 00:38:43 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4434f5f0845ff380c65da956e31f...

Powered by Google App Engine
This is Rietveld 408576698