Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Unified Diff: chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc

Issue 2746423002: Safe media metadata parser: create mojo client with MakeUnique<> (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc
diff --git a/chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc b/chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc
index 223e2a243ab2b6967b24482b591154a676f469c0..675f30e51054db20556a5d5b7d397ce49f16eae9 100644
--- a/chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc
+++ b/chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc
@@ -66,16 +66,13 @@ SafeMediaMetadataParser::~SafeMediaMetadataParser() = default;
void SafeMediaMetadataParser::StartOnIOThread(const DoneCallback& callback) {
DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
DCHECK(!utility_process_mojo_client_);
- DCHECK(!callback.is_null());
+ DCHECK(callback);
callback_ = callback;
- const base::string16 utility_process_name =
- l10n_util::GetStringUTF16(IDS_UTILITY_PROCESS_MEDIA_FILE_CHECKER_NAME);
-
- utility_process_mojo_client_.reset(
- new content::UtilityProcessMojoClient<extensions::mojom::MediaParser>(
- utility_process_name));
+ utility_process_mojo_client_ = base::MakeUnique<
+ content::UtilityProcessMojoClient<extensions::mojom::MediaParser>>(
+ l10n_util::GetStringUTF16(IDS_UTILITY_PROCESS_MEDIA_FILE_CHECKER_NAME));
utility_process_mojo_client_->set_error_callback(
base::Bind(&SafeMediaMetadataParser::ParseMediaMetadataFailed, this));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698