Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2750763003: Out-of-process file patcher: create mojo client with MakeUnique<> (Closed)

Created:
3 years, 9 months ago by Noel Gordon
Modified:
3 years, 9 months ago
Reviewers:
waffles, Sam McNally
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Out-of-process file patcher: create mojo client with MakeUnique<> Create the utility process mojo client with base::MakeUnique<>. No change in behavior, no new tests. BUG=597124 Review-Url: https://codereview.chromium.org/2750763003 Cr-Commit-Position: refs/heads/master@{#456893} Committed: https://chromium.googlesource.com/chromium/src/+/2ff97c10b4f5ba659bce7de71fa8cd6f818d3839

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M chrome/browser/component_updater/component_patcher_operation_out_of_process.cc View 1 chunk +3 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (13 generated)
Noel Gordon
3 years, 9 months ago (2017-03-14 13:17:16 UTC) #7
waffles
lgtm
3 years, 9 months ago (2017-03-14 17:06:06 UTC) #12
Sam McNally
lgtm
3 years, 9 months ago (2017-03-14 23:23:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750763003/1
3 years, 9 months ago (2017-03-14 23:33:51 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 23:41:46 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2ff97c10b4f5ba659bce7de71fa8...

Powered by Google App Engine
This is Rietveld 408576698