Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2746363002: Reland of move enable_vulkan from build/config, and move it to the buildflag_header system. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
CC:
chromium-reviews, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, cc-bugs_chromium.org, danakj+watch_chromium.org, piman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of move enable_vulkan from build/config, and move it to the buildflag_header system. (patchset #1 id:1 of https://codereview.chromium.org/2742263004/ ) Reason for revert: Relanding since this revert doesn't appear to have helped: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests Original issue's description: > Revert of Remove enable_vulkan from build/config, and move it to the buildflag_header system. (patchset #8 id:140001 of https://codereview.chromium.org/2744973002/ ) > > Reason for revert: > Speculative revert for linux tests failure: > https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests > > Original issue's description: > > Remove enable_vulkan from build/config, and move it to the buildflag_header system. > > > > No intended behavior change. > > > > TBR=avi > > BUG=none > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > > > Review-Url: https://codereview.chromium.org/2744973002 > > Cr-Commit-Position: refs/heads/master@{#456525} > > Committed: https://chromium.googlesource.com/chromium/src/+/7f118188c140989c8a633c60d531b4c08eef8564 > > TBR=dyen@chromium.org,danakj@chromium.org,jbauman@chromium.org,avi@chromium.org,piman@chromium.org,thakis@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=none > > Review-Url: https://codereview.chromium.org/2742263004 > Cr-Commit-Position: refs/heads/master@{#456562} > Committed: https://chromium.googlesource.com/chromium/src/+/0192171168e7afc337edc13c150eca4152185cd5 TBR=dyen@chromium.org,danakj@chromium.org,jbauman@chromium.org,avi@chromium.org,piman@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review-Url: https://codereview.chromium.org/2746363002 Cr-Commit-Position: refs/heads/master@{#456613} Committed: https://chromium.googlesource.com/chromium/src/+/db0a348759ea9c97783c516344a1d96880ceb359

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -30 lines) Patch
M build/config/ui.gni View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M cc/output/vulkan_in_process_context_provider.h View 2 chunks +2 lines, -1 line 0 comments Download
M cc/output/vulkan_in_process_context_provider.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M cc/surfaces/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M cc/surfaces/display.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M content/gpu/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/vulkan/BUILD.gn View 2 chunks +7 lines, -8 lines 0 comments Download
A gpu/vulkan/features.gni View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
qyearsley
Created Reland of move enable_vulkan from build/config, and move it to the buildflag_header system.
3 years, 9 months ago (2017-03-14 03:18:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746363002/1
3 years, 9 months ago (2017-03-14 03:18:38 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 03:25:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/db0a348759ea9c97783c516344a1...

Powered by Google App Engine
This is Rietveld 408576698