Revert of Remove enable_vulkan from build/config, and move it to the buildflag_header system.

Revert of Remove enable_vulkan from build/config, and move it to the buildflag_header system. (patchset #8 id:140001 of https://codereview.chromium.org/2744973002/ )

Reason for revert:
Speculative revert for linux tests failure:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests

Original issue's description:
> Remove enable_vulkan from build/config, and move it to the buildflag_header system.
> 
> No intended behavior change.
> 
> TBR=avi
> BUG=none
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Review-Url: https://codereview.chromium.org/2744973002
> Cr-Commit-Position: refs/heads/master@{#456525}
> Committed: https://chromium.googlesource.com/chromium/src/+/7f118188c140989c8a633c60d531b4c08eef8564

TBR=dyen@chromium.org,danakj@chromium.org,jbauman@chromium.org,avi@chromium.org,piman@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review-Url: https://codereview.chromium.org/2742263004
Cr-Commit-Position: refs/heads/master@{#456562}
Committed: https://chromium.googlesource.com/chromium/src/+/0192171168e7afc337edc13c150eca4152185cd5

[qyearsley, 2017-03-14 01:30:44]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2017-03-14 01:30:45]

Created Revert of Remove enable_vulkan from build/config, and move it to the
buildflag_header system.

[commit-bot: I haz the power, 2017-03-14 01:31:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 01:34:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489455044513100, "parent_rev":
"62b8e5996478c00373107e54311dd5966afddd4b", "commit_rev":
"0192171168e7afc337edc13c150eca4152185cd5"}

[commit-bot: I haz the power, 2017-03-14 01:35:17]

Description was changed from

==========
Revert of Remove enable_vulkan from build/config, and move it to the
buildflag_header system. (patchset #8 id:140001 of
https://codereview.chromium.org/2744973002/ )

Reason for revert:
Speculative revert for linux tests failure:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests

Original issue's description:
> Remove enable_vulkan from build/config, and move it to the buildflag_header
system.
> 
> No intended behavior change.
> 
> TBR=avi
> BUG=none
>
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Review-Url: https://codereview.chromium.org/2744973002
> Cr-Commit-Position: refs/heads/master@{#456525}
> Committed:
https://chromium.googlesource.com/chromium/src/+/7f118188c140989c8a633c60d531...

TBR=dyen@chromium.org,danakj@chromium.org,jbauman@chromium.org,avi@chromium.o...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none
==========

to

==========
Revert of Remove enable_vulkan from build/config, and move it to the
buildflag_header system. (patchset #8 id:140001 of
https://codereview.chromium.org/2744973002/ )

Reason for revert:
Speculative revert for linux tests failure:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests

Original issue's description:
> Remove enable_vulkan from build/config, and move it to the buildflag_header
system.
> 
> No intended behavior change.
> 
> TBR=avi
> BUG=none
>
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Review-Url: https://codereview.chromium.org/2744973002
> Cr-Commit-Position: refs/heads/master@{#456525}
> Committed:
https://chromium.googlesource.com/chromium/src/+/7f118188c140989c8a633c60d531...

TBR=dyen@chromium.org,danakj@chromium.org,jbauman@chromium.org,avi@chromium.o...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review-Url: https://codereview.chromium.org/2742263004
Cr-Commit-Position: refs/heads/master@{#456562}
Committed:
https://chromium.googlesource.com/chromium/src/+/0192171168e7afc337edc13c150e...
==========

[commit-bot: I haz the power, 2017-03-14 01:35:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0192171168e7afc337edc13c150e...

[Nico, 2017-03-14 01:35:57]

The cl is not in the blame list on the first red build:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/53070

On Mar 13, 2017 9:31 PM, "commit-bot@chromium.org via
codereview.chromium.org" <reply@chromiumcodereview-hr.appspotmail.com>
wrote:

> CQ is trying da patch. Follow status at
>
> https://chromium-cq-status.appspot.com/v2/patch-status/
> codereview.chromium.org/2742263004/1
>
>
> https://codereview.chromium.org/2742263004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[qyearsley, 2017-03-14 02:25:12]

On 2017/03/14 at 01:35:57, thakis wrote:
> The cl is not in the blame list on the first red build:
>
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/53070
> 

Ah, you're right -- the reason why I looked at this CL was because of the Findit
try job result:
https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.c...
which didn't start looking from build #53070.

It's possible that there may be multiple issues, but I'm not sure :-/

[Nico, 2017-03-14 02:44:11]

Can you reland if the revert doesn't help?

On Mar 13, 2017 10:25 PM, <qyearsley@chromium.org> wrote:

On 2017/03/14 at 01:35:57, thakis wrote:
> The cl is not in the blame list on the first red build:
>
https://build.chromium.org/p/chromium.linux/builders/Linux%
20Tests/builds/53070
>

Ah, you're right -- the reason why I looked at this CL was because of the
Findit
try job result:
https://findit-for-me.appspot.com/waterfall/build-failure?
url=https://build.chromium.org/p/chromium.linux/builders/
Linux%20Tests/builds/53072
which didn't start looking from build #53070.

It's possible that there may be multiple issues, but I'm not sure :-/


https://codereview.chromium.org/2742263004/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[qyearsley, 2017-03-14 03:18:07]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2746363002/ by qyearsley@chromium.org.

The reason for reverting is: Relanding since this revert doesn't appear to have
helped:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests.

[stgao, 2017-03-17 17:12:02]

On 2017/03/14 02:25:12, qyearsley wrote:
> On 2017/03/14 at 01:35:57, thakis wrote:
> > The cl is not in the blame list on the first red build:
> >
>
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/53070
> > 
> 
> Ah, you're right -- the reason why I looked at this CL was because of the
Findit
> try job result:
>
https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.c...
> which didn't start looking from build #53070.
> 
> It's possible that there may be multiple issues, but I'm not sure :-/

The false positive here is because the test is a test with low flakiness. And it
confused Findit on the regression range to look at.
I've filed a bug to track this
https://bugs.chromium.org/p/chromium/issues/detail?id=702682