Remove enable_vulkan from build/config, and move it to the buildflag_header system.

Remove enable_vulkan from build/config, and move it to the buildflag_header system.

No intended behavior change.

TBR=avi
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2744973002
Cr-Commit-Position: refs/heads/master@{#456525}
Committed: https://chromium.googlesource.com/chromium/src/+/7f118188c140989c8a633c60d531b4c08eef8564

[Nico, 2017-03-11 19:24:17]

Description was changed from

==========
Remove enable_vulkan from build/config, and move it to the buildflag_header
system.

No intended behavior change.

BUG=none
==========

to

==========
Remove enable_vulkan from build/config, and move it to the buildflag_header
system.

No intended behavior change.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Nico, 2017-03-11 19:24:18]

Description was changed from

==========
Remove enable_vulkan from build/config, and move it to the buildflag_header
system.

No intended behavior change.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove enable_vulkan from build/config, and move it to the buildflag_header
system.

No intended behavior change.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Nico, 2017-03-11 19:24:22]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 19:24:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-03-11 19:26:35]

thakis@chromium.org changed reviewers:
+ danakj@chromium.org, dyen@chromium.org

[Nico, 2017-03-11 19:26:36]

danakj: cc/
dyen: rest

Sorry, I screwed this up when reviewing
https://codereview.chromium.org/1726303002 . See build/buildflag_header.gni for
more information.

[commit-bot: I haz the power, 2017-03-11 19:27:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 19:27:20]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Nico, 2017-03-11 19:32:41]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 19:32:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 19:35:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 19:35:35]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)

[Nico, 2017-03-11 19:37:45]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 19:37:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 19:42:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 19:42:27]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Nico, 2017-03-11 20:52:18]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 20:52:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 20:57:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 20:57:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nico, 2017-03-11 20:59:45]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 20:59:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 21:57:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 21:57:05]

Dry run: This issue passed the CQ dry run.

[Nico, 2017-03-12 00:46:22]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-12 00:46:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-12 01:54:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-12 01:54:40]

Dry run: This issue passed the CQ dry run.

[danakj, 2017-03-13 15:13:59]

https://codereview.chromium.org/2744973002/diff/100001/gpu/vulkan/BUILD.gn
File gpu/vulkan/BUILD.gn (right):

https://codereview.chromium.org/2744973002/diff/100001/gpu/vulkan/BUILD.gn#ne...
gpu/vulkan/BUILD.gn:5: import("features.gni")
confirming this shouldn't be a path from the root?

https://codereview.chromium.org/2744973002/diff/100001/gpu/vulkan/features.gni
File gpu/vulkan/features.gni (right):

https://codereview.chromium.org/2744973002/diff/100001/gpu/vulkan/features.gn...
gpu/vulkan/features.gni:1: # Copyright 2016 The Chromium Authors. All rights
reserved.
2017

[Nico, 2017-03-13 15:19:30]

https://codereview.chromium.org/2744973002/diff/100001/gpu/vulkan/BUILD.gn
File gpu/vulkan/BUILD.gn (right):

https://codereview.chromium.org/2744973002/diff/100001/gpu/vulkan/BUILD.gn#ne...
gpu/vulkan/BUILD.gn:5: import("features.gni")
On 2017/03/13 15:13:59, danakj wrote:
> confirming this shouldn't be a path from the root?

relative imports are frequent when importing something in the same dir or in
subdirs:
https://cs.chromium.org/search/?q=import%5C(%5C%22%5B%5E/%5D+package:%5Echrom...

[danakj, 2017-03-13 16:04:54]

ok cc/ LGTM thanks

[Nico, 2017-03-13 21:23:05]

thakis@chromium.org changed reviewers:
+ avi@chromium.org, jbauman@chromium.org

[Nico, 2017-03-13 21:23:06]

jbauman, looks like dyen left and piman is on leave -- can you take a look at
the gpu/ bits?

avi: mechanical changes in content/

[Nico, 2017-03-13 21:24:02]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 21:25:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2017-03-13 21:34:19]

gpu/ lgtm (with copyright date change)

On 2017/03/13 21:23:06, Nico wrote:
> jbauman, looks like dyen left and piman is on leave -- can you take a look at
> the gpu/ bits?
> 
> avi: mechanical changes in content/

[piman, 2017-03-13 21:39:23]

piman@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2017-03-13 21:39:24]

lgtm

[Nico, 2017-03-13 21:40:58]

Description was changed from

==========
Remove enable_vulkan from build/config, and move it to the buildflag_header
system.

No intended behavior change.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove enable_vulkan from build/config, and move it to the buildflag_header
system.

No intended behavior change.

TBR=avi
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Nico, 2017-03-13 21:43:31]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-03-13 21:43:31]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
jbauman@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2744973002/#ps140001
(title: "awww year")

[commit-bot: I haz the power, 2017-03-13 21:44:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-03-13 22:10:21]

lgtm

stamp

[commit-bot: I haz the power, 2017-03-13 23:07:03]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1489441411283520,
"parent_rev": "554a52a54cc66abb2e1555180ec87df11c1709ae", "commit_rev":
"7f118188c140989c8a633c60d531b4c08eef8564"}

[commit-bot: I haz the power, 2017-03-13 23:07:46]

Description was changed from

==========
Remove enable_vulkan from build/config, and move it to the buildflag_header
system.

No intended behavior change.

TBR=avi
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove enable_vulkan from build/config, and move it to the buildflag_header
system.

No intended behavior change.

TBR=avi
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2744973002
Cr-Commit-Position: refs/heads/master@{#456525}
Committed:
https://chromium.googlesource.com/chromium/src/+/7f118188c140989c8a633c60d531...
==========

[commit-bot: I haz the power, 2017-03-13 23:07:49]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/7f118188c140989c8a633c60d531...

[qyearsley, 2017-03-14 01:30:44]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2742263004/ by qyearsley@chromium.org.

The reason for reverting is: Speculative revert for linux tests failure:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests.