Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2746103002: Let MockWebMediaPlayers in blink unit tests inherit from EmptyWebMediaPlayer (Closed)

Created:
3 years, 9 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 9 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dglazkov+blink, dshwang, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let MockWebMediaPlayers in blink unit tests inherit from EmptyWebMediaPlayer BUG=700848 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2746103002 Cr-Commit-Position: refs/heads/master@{#457066} Committed: https://chromium.googlesource.com/chromium/src/+/354f42fea111d3fc28d206c69fba4514aed1a849

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -102 lines) Patch
M third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetectorTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegateTest.cpp View 2 chunks +3 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp View 1 2 chunks +4 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/paint/VideoPainterTest.cpp View 3 chunks +2 lines, -32 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
Zhiqiang Zhang (Slow)
3 years, 9 months ago (2017-03-13 11:47:23 UTC) #5
mlamouri (slow - plz ping)
lgtm
3 years, 9 months ago (2017-03-13 18:25:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746103002/1
3 years, 9 months ago (2017-03-13 18:26:30 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/384097)
3 years, 9 months ago (2017-03-13 18:35:41 UTC) #12
Zhiqiang Zhang (Slow)
3 years, 9 months ago (2017-03-13 18:36:14 UTC) #14
Zhiqiang Zhang (Slow)
3 years, 9 months ago (2017-03-14 11:10:43 UTC) #16
jochen (gone - plz use gerrit)
lgtm
3 years, 9 months ago (2017-03-14 20:08:59 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746103002/20001
3 years, 9 months ago (2017-03-15 12:21:23 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 13:24:48 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/354f42fea111d3fc28d206c69fba...

Powered by Google App Engine
This is Rietveld 408576698