Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp

Issue 2746103002: Let MockWebMediaPlayers in blink unit tests inherit from EmptyWebMediaPlayer (Closed)
Patch Set: rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp
index 57ae09d64c1eee414e89d662e99f40990211065a..9a3f79b4c5b05b14017007db2bdc66c110579636 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp
@@ -17,9 +17,9 @@
#include "core/loader/EmptyClients.h"
#include "core/testing/DummyPageHolder.h"
#include "platform/heap/Handle.h"
+#include "platform/testing/EmptyWebMediaPlayer.h"
#include "platform/testing/HistogramTester.h"
#include "platform/testing/UnitTestHelpers.h"
-#include "public/platform/WebMediaPlayer.h"
#include "public/platform/WebSize.h"
#include "public/platform/modules/remoteplayback/WebRemotePlaybackAvailability.h"
#include "public/platform/modules/remoteplayback/WebRemotePlaybackClient.h"
@@ -29,42 +29,11 @@ namespace blink {
namespace {
-class MockVideoWebMediaPlayer : public WebMediaPlayer {
+class MockVideoWebMediaPlayer : public EmptyWebMediaPlayer {
public:
// WebMediaPlayer overrides:
- void load(LoadType, const WebMediaPlayerSource&, CORSMode) override{};
- void play() override{};
- void pause() override{};
- bool supportsSave() const override { return false; };
- void seek(double seconds) override{};
- void setRate(double) override{};
- void setVolume(double) override{};
- WebTimeRanges buffered() const override { return WebTimeRanges(); };
- WebTimeRanges seekable() const override { return m_seekable; };
- void setSinkId(const WebString& sinkId,
- const WebSecurityOrigin&,
- WebSetSinkIdCallbacks*) override{};
- bool hasVideo() const override { return true; };
- bool hasAudio() const override { return false; };
- WebSize naturalSize() const override { return WebSize(0, 0); };
- bool paused() const override { return false; };
- bool seeking() const override { return false; };
- double duration() const override { return 0.0; };
- double currentTime() const override { return 0.0; };
- NetworkState getNetworkState() const override { return NetworkStateEmpty; };
- ReadyState getReadyState() const override { return ReadyStateHaveNothing; };
- WebString getErrorMessage() override { return WebString(); };
- bool didLoadingProgress() override { return false; };
- bool hasSingleSecurityOrigin() const override { return true; };
- bool didPassCORSAccessCheck() const override { return true; };
- double mediaTimeForTimeValue(double timeValue) const override {
- return timeValue;
- };
- unsigned decodedFrameCount() const override { return 0; };
- unsigned droppedFrameCount() const override { return 0; };
- size_t audioDecodedByteCount() const override { return 0; };
- size_t videoDecodedByteCount() const override { return 0; };
- void paint(WebCanvas*, const WebRect&, PaintFlags&) override{};
+ WebTimeRanges seekable() const override { return m_seekable; }
+ bool hasVideo() const override { return true; }
WebTimeRanges m_seekable;
};

Powered by Google App Engine
This is Rietveld 408576698