Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: third_party/WebKit/Source/core/paint/VideoPainterTest.cpp

Issue 2746103002: Let MockWebMediaPlayers in blink unit tests inherit from EmptyWebMediaPlayer (Closed)
Patch Set: rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/VideoPainterTest.cpp
diff --git a/third_party/WebKit/Source/core/paint/VideoPainterTest.cpp b/third_party/WebKit/Source/core/paint/VideoPainterTest.cpp
index 2d6226760cd35a802b85d68a6fcb8b028a983d49..6b1fe211c232f5545921e2b933665e070afcf751 100644
--- a/third_party/WebKit/Source/core/paint/VideoPainterTest.cpp
+++ b/third_party/WebKit/Source/core/paint/VideoPainterTest.cpp
@@ -10,12 +10,12 @@
#include "core/loader/EmptyClients.h"
#include "core/paint/StubChromeClientForSPv2.h"
#include "core/testing/DummyPageHolder.h"
+#include "platform/testing/EmptyWebMediaPlayer.h"
#include "platform/testing/RuntimeEnabledFeaturesTestHelpers.h"
#include "platform/testing/UnitTestHelpers.h"
#include "public/platform/Platform.h"
#include "public/platform/WebCompositorSupport.h"
#include "public/platform/WebLayer.h"
-#include "public/platform/WebMediaPlayer.h"
#include "public/platform/WebSize.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -24,7 +24,7 @@
namespace blink {
namespace {
-class StubWebMediaPlayer : public WebMediaPlayer {
+class StubWebMediaPlayer : public EmptyWebMediaPlayer {
public:
StubWebMediaPlayer(WebMediaPlayerClient* client) : m_client(client) {}
@@ -39,38 +39,8 @@ class StubWebMediaPlayer : public WebMediaPlayer {
m_webLayer = Platform::current()->compositorSupport()->createLayer();
m_client->setWebLayer(m_webLayer.get());
}
- void play() override {}
- void pause() override {}
- bool supportsSave() const override { return false; }
- void seek(double seconds) override {}
- void setRate(double) override {}
- void setVolume(double) override {}
- WebTimeRanges buffered() const override { return WebTimeRanges(); }
- WebTimeRanges seekable() const override { return WebTimeRanges(); }
- void setSinkId(const WebString& sinkId,
- const WebSecurityOrigin&,
- WebSetSinkIdCallbacks*) override {}
- bool hasVideo() const override { return false; }
- bool hasAudio() const override { return false; }
- WebSize naturalSize() const override { return WebSize(0, 0); }
- bool paused() const override { return false; }
- bool seeking() const override { return false; }
- double duration() const override { return 0.0; }
- double currentTime() const override { return 0.0; }
NetworkState getNetworkState() const override { return m_networkState; }
ReadyState getReadyState() const override { return m_readyState; }
- WebString getErrorMessage() override { return WebString(); }
- bool didLoadingProgress() override { return false; }
- bool hasSingleSecurityOrigin() const override { return true; }
- bool didPassCORSAccessCheck() const override { return true; }
- double mediaTimeForTimeValue(double timeValue) const override {
- return timeValue;
- }
- unsigned decodedFrameCount() const override { return 0; }
- unsigned droppedFrameCount() const override { return 0; }
- size_t audioDecodedByteCount() const override { return 0; }
- size_t videoDecodedByteCount() const override { return 0; }
- void paint(WebCanvas*, const WebRect&, PaintFlags&) override {}
private:
WebMediaPlayerClient* m_client;
« no previous file with comments | « third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698