Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2746033005: MD Settings: Separate code to be loaded lazily to its own lazy_load.html (Closed)

Created:
3 years, 9 months ago by dpapad
Modified:
3 years, 9 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Separate code to be loaded lazily to its own lazy_load.html This CL does not change the way the advanced page is loaded. It is still loads during startup as before. This is a preparatory step/trick, that allows landing all the BUILD configuration changes first, before dealing with the lazy loading logic. BUG=597347 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2746033005 Cr-Commit-Position: refs/heads/master@{#457574} Committed: https://chromium.googlesource.com/chromium/src/+/06614e256a13dd528d165d33c30c158f225834d7

Patch Set 1 #

Patch Set 2 : Add missing file. #

Patch Set 3 : Fix crisper output. #

Messages

Total messages: 20 (15 generated)
dpapad
3 years, 9 months ago (2017-03-15 07:38:59 UTC) #13
Dan Beam
lgtm
3 years, 9 months ago (2017-03-15 16:26:07 UTC) #14
dpapad
On 2017/03/15 at 16:26:07, dbeam wrote: > lgtm Thanks. This CL depends on the Vulcanize ...
3 years, 9 months ago (2017-03-15 17:20:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746033005/40001
3 years, 9 months ago (2017-03-16 20:48:42 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 21:54:02 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/06614e256a13dd528d165d33c30c...

Powered by Google App Engine
This is Rietveld 408576698