chrome/browser/resources/vulcanize_gn.py - Issue 2746033005: MD Settings: Separate code to be loaded lazily to its own lazy_load.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/vulcanize_gn.py

Issue 2746033005: MD Settings: Separate code to be loaded lazily to its own lazy_load.html (Closed)

Patch Set: Fix crisper output. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/vulcanize_gn.py

diff --git a/chrome/browser/resources/vulcanize_gn.py b/chrome/browser/resources/vulcanize_gn.py

index 834bca1bf58a01d12667dc7721f0cc709efb3773..309ab32be4bb53533003a2116b68bdb96f1cee12 100755

--- a/chrome/browser/resources/vulcanize_gn.py

+++ b/chrome/browser/resources/vulcanize_gn.py

@@ -168,6 +168,10 @@ def _vulcanize(in_folder, args):

'--html', html_out_path,

'--js', js_out_path])

+ # Create an empty JS file if crisper did not create one.

+ if not os.path.isfile(js_out_path):

+ open(js_out_path, 'w').close()

node.RunNode([node_modules.PathToUglifyJs(), js_out_path,

'--comments', '"/Copyright|license|LICENSE|\<\/?if/"',

'--output', js_out_path])