Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2733143002: WebUI: Locally patch vulcanize to not load excluded JS files. (Closed)

Created:
3 years, 9 months ago by dpapad
Modified:
3 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Locally patch vulcanize to not load excluded JS files. https://github.com/Polymer/polymer-bundler/pull/442/ BUG=597347 Review-Url: https://codereview.chromium.org/2733143002 Cr-Commit-Position: refs/heads/master@{#457536} Committed: https://chromium.googlesource.com/chromium/src/+/92c1a4cf87397d9a63c6e1bc0bb6ecc141a0979c

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M third_party/node/node_modules.tar.gz.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/node/patch_vulcanize.diff View 1 chunk +30 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
dpapad
3 years, 9 months ago (2017-03-16 19:13:47 UTC) #2
Dan Beam
lgtm
3 years, 9 months ago (2017-03-16 19:34:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733143002/80001
3 years, 9 months ago (2017-03-16 19:37:02 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 20:27:41 UTC) #11
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/92c1a4cf87397d9a63c6e1bc0bb6...

Powered by Google App Engine
This is Rietveld 408576698