WIP: Modified AXPosition to work with objects with both embedded object characters and text.

WIP: Modified AXPosition to work with objects with both embedded object characters and text.

On Windows, I had assumed that we would use tree positions for non text nobjects and text positions for text objects. This can work only if IA2 hypertext contains either a series of embedded object characters or text, but not both.
However, the fact that we append the text of each static text object to its immediate parent for performance reasons, means that we could potentially have IA2 hypertext that contains both embedded object characters and text.
BUG=700214
R=dmazzoni@chromium.org
TESTED=not yet

Review-Url: https://codereview.chromium.org/2745713002
Cr-Commit-Position: refs/heads/master@{#457665}
Committed: https://chromium.googlesource.com/chromium/src/+/4089977fdebad10fac160d2a43d65b97f00d92ab

[dmazzoni, 2017-03-10 19:32:25]

lgtm

https://codereview.chromium.org/2745713002/diff/1/content/browser/accessibili...
File content/browser/accessibility/ax_platform_position.cc (right):

https://codereview.chromium.org/2745713002/diff/1/content/browser/accessibili...
content/browser/accessibility/ax_platform_position.cc:102: #if defined(OS_WIN)
|| \
Nit: put the #if inside the function, not outside it.

Add a comment explaining the different semantics of
MaxTextOffsetInParent.

[nektarios, 2017-03-17 01:58:59]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2017-03-17 01:58:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2745713002/#ps40001
(title: "Moved tests and Win changes to another patch.")

[commit-bot: I haz the power, 2017-03-17 01:59:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 02:49:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489715939537400,
"parent_rev": "a07f851c69871c9ee213e2e1a119c14e60154936", "commit_rev":
"4089977fdebad10fac160d2a43d65b97f00d92ab"}

[commit-bot: I haz the power, 2017-03-17 02:50:26]

Description was changed from

==========
WIP: Modified AXPosition to work with objects with both embedded object
characters and text.

On Windows, I had assumed that we would use tree positions for non text nobjects
and text positions for text objects. This can work only if IA2 hypertext
contains either a series of embedded object characters or text, but not both.
However, the fact that we append the text of each static text object to its
immediate parent for performance reasons, means that we could potentially have
IA2 hypertext that contains both embedded object characters and text.
BUG=700214
R=dmazzoni@chromium.org
TESTED=not yet
==========

to

==========
WIP: Modified AXPosition to work with objects with both embedded object
characters and text.

On Windows, I had assumed that we would use tree positions for non text nobjects
and text positions for text objects. This can work only if IA2 hypertext
contains either a series of embedded object characters or text, but not both.
However, the fact that we append the text of each static text object to its
immediate parent for performance reasons, means that we could potentially have
IA2 hypertext that contains both embedded object characters and text.
BUG=700214
R=dmazzoni@chromium.org
TESTED=not yet

Review-Url: https://codereview.chromium.org/2745713002
Cr-Commit-Position: refs/heads/master@{#457665}
Committed:
https://chromium.googlesource.com/chromium/src/+/4089977fdebad10fac160d2a43d6...
==========

[commit-bot: I haz the power, 2017-03-17 02:50:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4089977fdebad10fac160d2a43d6...