third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp - Issue 2745713002: WIP: Modified AXPosition to work with objects with both embedded object characters and text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

Issue 2745713002: WIP: Modified AXPosition to work with objects with both embedded object characters and text. (Closed)

Patch Set: Simplified and cleaned up selection code in Blink > Accessibility. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/ax_platform_position.cc ('k') | third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp b/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

index 305dfbc8c7b761ac70e59763a18fceae1ee396da..9059f12b9f6cf9e5094a335cc930d2dc70e59204 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

@@ -118,10 +118,11 @@ void AXInlineTextBox::GetWordBoundaries(Vector<AXRange>& words) const {

Vector<AbstractInlineTextBox::WordBoundaries> word_boundaries;

inline_text_box_->GetWordBoundaries(word_boundaries);

- words.resize(word_boundaries.size());

- for (unsigned i = 0; i < word_boundaries.size(); i++)

- words[i] =

- AXRange(word_boundaries[i].start_index, word_boundaries[i].end_index);

+ for (unsigned i = 0; i < word_boundaries.size(); i++) {

+ words.emplace_back(

+ const_cast<AXInlineTextBox*>(this), word_boundaries[i].start_index,

+ const_cast<AXInlineTextBox*>(this), word_boundaries[i].end_index);

+ }

}

String AXInlineTextBox::GetName(