third_party/WebKit/Source/modules/accessibility/AXNodeObject.h - Issue 2745713002: WIP: Modified AXPosition to work with objects with both embedded object characters and text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

Issue 2745713002: WIP: Modified AXPosition to work with objects with both embedded object characters and text. (Closed)

Patch Set: Simplified and cleaned up selection code in Blink > Accessibility. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

diff --git a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

index 0b779ef6bfd8cd3aa4dd60c919dc42edda514a7a..6ad03703a61860a33a4a5aa661351c8a378e6db3 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

+++ b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

@@ -184,6 +184,9 @@ class MODULES_EXPORT AXNodeObject : public AXObjectImpl {

String Placeholder(AXNameFrom) const override;

bool NameFromLabelElement() const override;

+ // Selection.

+ AXRange Selection() const override;

// Location

void GetRelativeBounds(AXObjectImpl** out_container,

FloatRect& out_bounds_in_container,