Implement the events for Background Fetch

Implement the events for Background Fetch

This CL implements the events for Background Fetch. There are four:

  - BackgroundFetchEvent (onbackgroundfetchabort; base event)
  - BackgroundFetchClickEvent (onbackgroundfetchclick)
  - BackgroundFetchedEvent (onbackgroundfetched)
  - BackgroundFetchFailEvent (onbackgroundfetchfail)

Not all attributes are supported yet. Notably, the sequences of requests
and responses associated with a fetch will be exposed in a subsequent CL.

Tests are included, and are in addition to the IDL harness test in WPT.
I'm adding tests for the `fail` and `fetched` events in the next CL,
where they get Request and Response knowledge.

BUG=692534
Review-Url: https://codereview.chromium.org/2745573002
Cr-Commit-Position: refs/heads/master@{#456296}
Committed: https://chromium.googlesource.com/chromium/src/+/4c13484884ae6388d116d6d9d84c9fc42479630d

[Peter Beverloo, 2017-03-09 15:01:47]

peter@chromium.org changed reviewers:
+ harkness@chromium.org

[Peter Beverloo, 2017-03-09 15:01:48]

+harkness

[harkness, 2017-03-09 19:41:15]

lgtm

https://codereview.chromium.org/2745573002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-click-event.https.html
(right):

https://codereview.chromium.org/2745573002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-click-event.https.html:17:
// This test needs to be ran in a Service Worker.
micro-nit: run

https://codereview.chromium.org/2745573002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-event.https.html
(right):

https://codereview.chromium.org/2745573002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-event.https.html:17:
// This test needs to be ran in a Service Worker.
micro-nit: run

https://codereview.chromium.org/2745573002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-click-event-worker.js
(right):

https://codereview.chromium.org/2745573002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-click-event-worker.js:16:
new BackgroundFetchClickEvent('BackgroundFetchClickEvent', { tag: 'foo', state
});
Are there tag formats that we won't allow?

https://codereview.chromium.org/2745573002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-click-event-worker.js:23:
assert_equals(event.type, 'BackgroundFetchClickEvent');
Why not check these in the for loop above for each state and remove this one?

[Peter Beverloo, 2017-03-10 00:36:40]

Description was changed from

==========
Implement the events for Background Fetch

This CL implements the events for Background Fetch. There are four:

  - BackgroundFetchEvent (onbackgroundfetchabort; base event)
  - BackgroundFetchClickEvent (onbackgroundfetchclick)
  - BackgroundFetchedEvent (onbackgroundfetched)
  - BackgroundFetchFailEvent (onbackgroundfetchfail)

Not all attributes are supported yet. Notably, the sequences of requests
and responses associated with a fetch will be exposed in a subsequent CL.

BUG=692534
==========

to

==========
Implement the events for Background Fetch

This CL implements the events for Background Fetch. There are four:

  - BackgroundFetchEvent (onbackgroundfetchabort; base event)
  - BackgroundFetchClickEvent (onbackgroundfetchclick)
  - BackgroundFetchedEvent (onbackgroundfetched)
  - BackgroundFetchFailEvent (onbackgroundfetchfail)

Not all attributes are supported yet. Notably, the sequences of requests
and responses associated with a fetch will be exposed in a subsequent CL.

Tests are included, and are in addition to the IDL harness test in WPT.
I'm adding tests for the `fail` and `fetched` events in the next CL,
where they get Request and Response knowledge.

BUG=692534
==========

[Peter Beverloo, 2017-03-10 00:42:49]

peter@chromium.org changed reviewers:
+ haraken@chromium.org

[Peter Beverloo, 2017-03-10 00:42:50]

+haraken, this one too. It looks sizeable but it's really four times the same
thing.

https://codereview.chromium.org/2745573002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-click-event-worker.js
(right):

https://codereview.chromium.org/2745573002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-click-event-worker.js:16:
new BackgroundFetchClickEvent('BackgroundFetchClickEvent', { tag: 'foo', state
});
On 2017/03/09 19:41:15, harkness wrote:
> Are there tag formats that we won't allow?

No, it follows the semantics of a DOMString.

https://codereview.chromium.org/2745573002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-click-event-worker.js:23:
assert_equals(event.type, 'BackgroundFetchClickEvent');
On 2017/03/09 19:41:15, harkness wrote:
> Why not check these in the for loop above for each state and remove this one?

Logically line 15/16 are testing that the allowed values don't fail, this is
testing that the event has the right properties (type, cancelable, bubbling and
so on). I don't feel strongly.

[haraken, 2017-03-10 09:36:34]

LGTM

https://codereview.chromium.org/2745573002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/background_fetch/BackgroundFetchEvent.h
(right):

https://codereview.chromium.org/2745573002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/background_fetch/BackgroundFetchEvent.h:38:
String m_tag;

Maybe we want to use AtomicString because it should be one of the pre-defined
strings.

[Peter Beverloo, 2017-03-10 14:03:49]

Thank you!

https://codereview.chromium.org/2745573002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-click-event.https.html
(right):

https://codereview.chromium.org/2745573002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-click-event.https.html:17:
// This test needs to be ran in a Service Worker.
On 2017/03/09 19:41:15, harkness wrote:
> micro-nit: run
> 

Done.

https://codereview.chromium.org/2745573002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-event.https.html
(right):

https://codereview.chromium.org/2745573002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-event.https.html:17:
// This test needs to be ran in a Service Worker.
On 2017/03/09 19:41:15, harkness wrote:
> micro-nit: run

Done.

https://codereview.chromium.org/2745573002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/background_fetch/BackgroundFetchEvent.h
(right):

https://codereview.chromium.org/2745573002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/background_fetch/BackgroundFetchEvent.h:38:
String m_tag;
On 2017/03/10 09:36:33, haraken wrote:
> 
> Maybe we want to use AtomicString because it should be one of the pre-defined
> strings.

Done for m_state in BackgroundFetchClickEvent, which is an enum. The `tag` is a
random developer-provided string.

[Peter Beverloo, 2017-03-12 01:00:50]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2017-03-12 01:00:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, harkness@chromium.org
Link to the patchset: https://codereview.chromium.org/2745573002/#ps60001
(title: "more webexposed tests")

[commit-bot: I haz the power, 2017-03-12 01:01:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-12 02:34:12]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489280450166610,
"parent_rev": "c82e7cd94a765fc3bd9ccc25c4b2556998709371", "commit_rev":
"4c13484884ae6388d116d6d9d84c9fc42479630d"}

[commit-bot: I haz the power, 2017-03-12 02:35:55]

Description was changed from

==========
Implement the events for Background Fetch

This CL implements the events for Background Fetch. There are four:

  - BackgroundFetchEvent (onbackgroundfetchabort; base event)
  - BackgroundFetchClickEvent (onbackgroundfetchclick)
  - BackgroundFetchedEvent (onbackgroundfetched)
  - BackgroundFetchFailEvent (onbackgroundfetchfail)

Not all attributes are supported yet. Notably, the sequences of requests
and responses associated with a fetch will be exposed in a subsequent CL.

Tests are included, and are in addition to the IDL harness test in WPT.
I'm adding tests for the `fail` and `fetched` events in the next CL,
where they get Request and Response knowledge.

BUG=692534
==========

to

==========
Implement the events for Background Fetch

This CL implements the events for Background Fetch. There are four:

  - BackgroundFetchEvent (onbackgroundfetchabort; base event)
  - BackgroundFetchClickEvent (onbackgroundfetchclick)
  - BackgroundFetchedEvent (onbackgroundfetched)
  - BackgroundFetchFailEvent (onbackgroundfetchfail)

Not all attributes are supported yet. Notably, the sequences of requests
and responses associated with a fetch will be exposed in a subsequent CL.

Tests are included, and are in addition to the IDL harness test in WPT.
I'm adding tests for the `fail` and `fetched` events in the next CL,
where they get Request and Response knowledge.

BUG=692534

Review-Url: https://codereview.chromium.org/2745573002
Cr-Commit-Position: refs/heads/master@{#456296}
Committed:
https://chromium.googlesource.com/chromium/src/+/4c13484884ae6388d116d6d9d84c...
==========

[commit-bot: I haz the power, 2017-03-12 02:35:57]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4c13484884ae6388d116d6d9d84c...