Implement the Request/Response bits of Background Fetch

Implement the Request/Response bits of Background Fetch

This CL implements the parts of the Background Fetch API that deal with
requests and responses, notably in the events. Following this, the Web
Exposed API that we're aiming for in MVP is implemented.

Tests for the `backgroundfetched` and `backgroundfetchfail` events have
been added, pending upstreaming to WPT like the others.

BUG=692534
Review-Url: https://codereview.chromium.org/2744873002
Cr-Commit-Position: refs/heads/master@{#456383}
Committed: https://chromium.googlesource.com/chromium/src/+/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd

[Peter Beverloo, 2017-03-10 18:09:50]

peter@chromium.org changed reviewers:
+ haraken@chromium.org, harkness@chromium.org

[Peter Beverloo, 2017-03-10 18:09:50]

+haraken, harkness

Last plumbing CL, the exposed API is now complete :). Next up is the Mojo
service, then hooking up the Service Worker events. Thank you so much for the
reviews so far!!

[harkness, 2017-03-13 12:43:07]

lgtm

https://codereview.chromium.org/2744873002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-fail-event-worker.js
(right):

https://codereview.chromium.org/2744873002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-fail-event-worker.js:8:
// The `tag` and `failedFetches` are required in the
BackgroundFetchFailEventInit.
nit: Maybe put that failedFetches needs a particular type, since otherwise it's
confusing why line 12 throws.

https://codereview.chromium.org/2744873002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetched-event-worker.js
(right):

https://codereview.chromium.org/2744873002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetched-event-worker.js:8:
// The `tag` and `completedFetches` are required in the
BackgroundFetchedEventInit.
nit: same comment re: completedFetches.

https://codereview.chromium.org/2744873002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
(right):

https://codereview.chromium.org/2744873002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt:25:
interface BackgroundFetchSettledRequest : BackgroundFetchRequest
I've opened a discussion in chat, but I would love to see both getters on the
Events named "completedFetches" because then this could also be
BackgroundFetchCompletedRequest.

[Peter Beverloo, 2017-03-13 13:23:09]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[Peter Beverloo, 2017-03-13 13:23:17]

https://codereview.chromium.org/2744873002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-fail-event-worker.js
(right):

https://codereview.chromium.org/2744873002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-fail-event-worker.js:8:
// The `tag` and `failedFetches` are required in the
BackgroundFetchFailEventInit.
On 2017/03/13 12:43:07, harkness wrote:
> nit: Maybe put that failedFetches needs a particular type, since otherwise
it's
> confusing why line 12 throws.

Done.

https://codereview.chromium.org/2744873002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetched-event-worker.js
(right):

https://codereview.chromium.org/2744873002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetched-event-worker.js:8:
// The `tag` and `completedFetches` are required in the
BackgroundFetchedEventInit.
On 2017/03/13 12:43:07, harkness wrote:
> nit: same comment re: completedFetches.

Done.

https://codereview.chromium.org/2744873002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
(right):

https://codereview.chromium.org/2744873002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt:25:
interface BackgroundFetchSettledRequest : BackgroundFetchRequest
On 2017/03/13 12:43:07, harkness wrote:
> I've opened a discussion in chat, but I would love to see both getters on the
> Events named "completedFetches" because then this could also be
> BackgroundFetchCompletedRequest. 

Acknowledged. Please file a spec bug here too:

https://github.com/WICG/background-fetch/issues

[commit-bot: I haz the power, 2017-03-13 13:23:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-03-13 13:30:18]

Implementation-wise LGTM.

[commit-bot: I haz the power, 2017-03-13 15:00:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 15:00:29]

Dry run: This issue passed the CQ dry run.

[Peter Beverloo, 2017-03-13 15:15:46]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2017-03-13 15:15:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
harkness@chromium.org
Link to the patchset: https://codereview.chromium.org/2744873002/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2017-03-13 15:16:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 15:22:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489418146911710,
"parent_rev": "b60da33b6f5c36296aa7ce76a2390034a7b4ba75", "commit_rev":
"f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd"}

[commit-bot: I haz the power, 2017-03-13 15:23:06]

Description was changed from

==========
Implement the Request/Response bits of Background Fetch

This CL implements the parts of the Background Fetch API that deal with
requests and responses, notably in the events. Following this, the Web
Exposed API that we're aiming for in MVP is implemented.

Tests for the `backgroundfetched` and `backgroundfetchfail` events have
been added, pending upstreaming to WPT like the others.

BUG=692534
==========

to

==========
Implement the Request/Response bits of Background Fetch

This CL implements the parts of the Background Fetch API that deal with
requests and responses, notably in the events. Following this, the Web
Exposed API that we're aiming for in MVP is implemented.

Tests for the `backgroundfetched` and `backgroundfetchfail` events have
been added, pending upstreaming to WPT like the others.

BUG=692534

Review-Url: https://codereview.chromium.org/2744873002
Cr-Commit-Position: refs/heads/master@{#456383}
Committed:
https://chromium.googlesource.com/chromium/src/+/f0a182b5ebc9c86a6dd3df10cb0e...
==========

[commit-bot: I haz the power, 2017-03-13 15:23:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f0a182b5ebc9c86a6dd3df10cb0e...