Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2745543002: Implement BackgroundFetchManager::{get, fetch}() (Closed)

Created:
3 years, 9 months ago by Peter Beverloo
Modified:
3 years, 9 months ago
Reviewers:
haraken, harkness
CC:
chromium-reviews, Peter Beverloo, blink-reviews, haraken, harkness+watch_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement BackgroundFetchManager::{get, fetch}() This CL implements the get() and fetch() methods for Background Fetch. The BackgroundFetchRegistration interface and BackgroundFetchOptions and IconDefinition dictionary types are added too. The method has not been hooked up with the browser process yet, as the Mojo interface has not been implemented yet. Tests are provided, and will be moved to the WPT directory once it has been approved upstream: https://github.com/w3c/web-platform-tests/pull/5094 BUG=692534 Review-Url: https://codereview.chromium.org/2745543002 Cr-Commit-Position: refs/heads/master@{#456144} Committed: https://chromium.googlesource.com/chromium/src/+/6e65af76a14bb2230117cf4bc7dfc76d5a4ed24b

Patch Set 1 #

Patch Set 2 : webexposed tests #

Patch Set 3 : more webexposed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -47 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-manager-fetch.https.html View 1 chunk +67 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-manager-get.https.html View 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-manager-getTags.https.html View 1 chunk +46 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/background_fetch/getTags.html View 1 chunk +0 lines, -41 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/background_fetch/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.h View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp View 2 chunks +67 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.idl View 1 chunk +4 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/modules/background_fetch/BackgroundFetchOptions.idl View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.h View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.cpp View 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.idl View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/background_fetch/IconDefinition.idl View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 3 chunks +7 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
Peter Beverloo
+harkness
3 years, 9 months ago (2017-03-09 13:09:30 UTC) #3
harkness
lgtm
3 years, 9 months ago (2017-03-09 19:26:25 UTC) #4
Peter Beverloo
+haraken, may I ask you to take a look? (Updates to the webexposed tests are ...
3 years, 9 months ago (2017-03-10 00:41:46 UTC) #6
haraken
LGTM
3 years, 9 months ago (2017-03-10 09:45:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745543002/40001
3 years, 9 months ago (2017-03-10 18:08:54 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 20:09:06 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6e65af76a14bb2230117cf4bc7df...

Powered by Google App Engine
This is Rietveld 408576698