Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2736143003: Introduce the Background Fetch module. (Closed)

Created:
3 years, 9 months ago by Peter Beverloo
Modified:
3 years, 9 months ago
Reviewers:
haraken, harkness
CC:
chromium-reviews, awdf+watch_chromium.org, Peter Beverloo, abarth-chromium, haraken, blink-reviews, kinuko+watch, harkness+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce the Background Fetch module. This CL introduces the BackgroundFetchManager object and exposes it on the ServiceWorkerRegistration, as part of a new Background Fetch module. More functionality and tests will be added iteratively. Intent to Implement: https://groups.google.com/a/chromium.org/d/topic/blink-dev/Ia9_-CVrl1U/discussion WPT directory addition + IDL harness tests: https://github.com/w3c/web-platform-tests/pull/5094 Based on the following CL by awdf@: https://codereview.chromium.org/2739653002/ BUG=692534 Review-Url: https://codereview.chromium.org/2736143003 Cr-Commit-Position: refs/heads/master@{#456102} Committed: https://chromium.googlesource.com/chromium/src/+/911ea3c964671fb131a49c7be4225a30ea9468e2

Patch Set 1 : Introduce the BackgroundFetchManager object. #

Patch Set 2 : IWYU #

Total comments: 2

Patch Set 3 : Introduce the BackgroundFetchManager object. #

Patch Set 4 : webexposed tests #

Patch Set 5 : more webexposed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/background_fetch/getTags.html View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/empty-worker.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/navigation-preload-origin-trial-interfaces-expected.txt View 1 2 3 4 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/chromium/navigation-preload-origin-trial-interfaces-expected.txt View 1 2 3 4 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/chromium/navigation-preload-origin-trial-interfaces-expected.txt View 1 2 3 4 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/background_fetch/BUILD.gn View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.h View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.idl View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/background_fetch/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/background_fetch/ServiceWorkerRegistrationBackgroundFetch.h View 1 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/background_fetch/ServiceWorkerRegistrationBackgroundFetch.cpp View 1 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/background_fetch/ServiceWorkerRegistrationBackgroundFetch.idl View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 28 (18 generated)
Peter Beverloo
+haraken, harkness for review
3 years, 9 months ago (2017-03-08 18:10:21 UTC) #9
haraken
In terms of implementation, LGTM.
3 years, 9 months ago (2017-03-08 18:27:58 UTC) #10
harkness
LGTM https://codereview.chromium.org/2736143003/diff/60001/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.h File third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.h (right): https://codereview.chromium.org/2736143003/diff/60001/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.h#newcode18 third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.h:18: class BackgroundFetchManager final nit: Add an overall comment ...
3 years, 9 months ago (2017-03-09 12:16:46 UTC) #11
Peter Beverloo
https://codereview.chromium.org/2736143003/diff/60001/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.h File third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.h (right): https://codereview.chromium.org/2736143003/diff/60001/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.h#newcode18 third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.h:18: class BackgroundFetchManager final On 2017/03/09 12:16:46, harkness wrote: > ...
3 years, 9 months ago (2017-03-09 15:02:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736143003/80001
3 years, 9 months ago (2017-03-09 15:02:59 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/397840)
3 years, 9 months ago (2017-03-09 16:42:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736143003/100001
3 years, 9 months ago (2017-03-10 13:46:00 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/406480)
3 years, 9 months ago (2017-03-10 15:12:36 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736143003/120001
3 years, 9 months ago (2017-03-10 15:40:49 UTC) #25
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 18:00:29 UTC) #28
Message was sent while issue was closed.
Committed patchset #5 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/911ea3c964671fb131a49c7be422...

Powered by Google App Engine
This is Rietveld 408576698