Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2745433004: Revert of webrtc-internals: dont remove tab (Closed)

Created:
3 years, 9 months ago by fserb
Modified:
3 years, 9 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of webrtc-internals: dont remove tab (patchset #1 id:1 of https://codereview.chromium.org/2739443002/ ) Reason for revert: This is breaking some Mac builds https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/14781 Original issue's description: > webrtc-internals: dont remove tab > > instead of removing the tab when a peerconnection is garbage collected > this adds a symbol which removes the tab on click. > > BUG=416876 > > Review-Url: https://codereview.chromium.org/2739443002 > Cr-Commit-Position: refs/heads/master@{#455743} > Committed: https://chromium.googlesource.com/chromium/src/+/b31e6f5fc2cae4ce8efdb57eb995a0c2e583dd75 TBR=guidou@chromium.org,tommi@chromium.org,philipp.hancke@googlemail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=416876 Review-Url: https://codereview.chromium.org/2745433004 Cr-Commit-Position: refs/heads/master@{#455760} Committed: https://chromium.googlesource.com/chromium/src/+/3c1769f9cb0518af8c81152741e7131b1f90473e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M content/browser/resources/media/tab_view.js View 1 chunk +0 lines, -11 lines 0 comments Download
M content/browser/resources/media/webrtc_internals.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
fserb
Created Revert of webrtc-internals: dont remove tab
3 years, 9 months ago (2017-03-09 16:22:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745433004/1
3 years, 9 months ago (2017-03-09 16:23:15 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 16:27:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3c1769f9cb0518af8c81152741e7...

Powered by Google App Engine
This is Rietveld 408576698