Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Unified Diff: content/browser/resources/media/webrtc_internals.js

Issue 2745433004: Revert of webrtc-internals: dont remove tab (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/resources/media/tab_view.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/resources/media/webrtc_internals.js
diff --git a/content/browser/resources/media/webrtc_internals.js b/content/browser/resources/media/webrtc_internals.js
index 86e4150820f91c4f112dc17199805f51700cc19c..8ada8ade8d36b0ae622ebae3d4ed457ee1d047e1 100644
--- a/content/browser/resources/media/webrtc_internals.js
+++ b/content/browser/resources/media/webrtc_internals.js
@@ -181,8 +181,7 @@
var element = $(getPeerConnectionId(data));
if (element) {
delete peerConnectionDataStore[element.id];
- // add a [x] button to close this tab instead of removing it immediately.
- tabView.makeTabRemovable(element.id);
+ tabView.removeTab(element.id);
}
}
« no previous file with comments | « content/browser/resources/media/tab_view.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698